fix(acp): log child process stderr + global name alias (#3135, #3134)#3147
Merged
Conversation
![aegis-gh-agent[bot]](https://avatars.githubusercontent.com/u/106186915?s=60&v=4){kind=small}
- Forward ACP child process stderr to server logs so errors from claude-agent-acp (API key issues, crashes) are visible for debugging - Move 'name' alias from create-only to redactSession() so it's present in all session responses (GET, list, create)
OneStepAt4time
force-pushed
the
fix/3135-acp-stderr-logging
branch
from
b242610 to
f44cd80
Compare
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Two issues:
ACP child process stderr is silently discarded — when
claude-agent-acpencounters errors (invalid API key, connection failures, crashes), they're written to stderr but never captured. This makes diagnosing ACP handshake failures (bug: ACP JSON-RPC timeout — sessions stuck at pending, CC process never spawns #3135) extremely difficult.namealias only in create response — PR fix(api): add 'name' alias to session create response (#3134) #3144 addedname: displayNamealias only to the create session response. GET and list endpoints still return onlydisplayName, notname.Fix
ACP stderr forwarding: Attach
stderrlistener toAcpChildProcessincreateDefaultAcpBackendClient. All stderr output is logged with session ID prefix for debugging.Global name alias: Move the alias from create-only to
redactSession()so it appears in ALL session responses (GET, list, create).Files
src/services/acp/backend.ts: forward child process stderrsrc/routes/context.ts: add name alias in redactSessionsrc/routes/sessions.ts: remove duplicate alias (now global)