chore(release): bump version to 0.6.7-preview.1#3203
Merged
Conversation
- package.json: 0.6.6-preview.1 β 0.6.7-preview.1 - .release-please-manifest.json: 0.6.5-preview.3 β 0.6.7-preview.1 - Helm charts: version + appVersion aligned
Contributor
There was a problem hiding this comment.
ποΈ Argus Review β Changes Requested
π Bug: Malformed JSON key in .release-please-manifest.json
The PR introduces a typo in the JSON key:
Current (develop): {".": "0.6.5-preview.3"}
PR (broken): {".".": "0.6.7-preview.1"}
The key should be "." (dot), not "."." (dot-dot). This will break release-please parsing.
Fix
Change line 1 of .release-please-manifest.json to:
{".": "0.6.7-preview.1"}Other Files β
package.json: version bump correct (0.6.6-preview.1β0.6.7-preview.1)charts/aegis/Chart.yaml: version + appVersion aligneddeploy/helm/aegis/Chart.yaml: version + appVersion aligned
Everything else is clean. Fix the JSON key and this is ready to merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Version Bump: 0.6.6-preview.1 β 0.6.7-preview.1
Prepares the codebase for the v0.6.7 release cycle.
Changes
package.json:0.6.6-preview.1β0.6.7-preview.1.release-please-manifest.json:0.6.5-preview.3β0.6.7-preview.1(was stale β last updated in v0.6.5 era)deploy/helm/aegis/Chart.yaml: version + appVersion alignedcharts/aegis/Chart.yaml: version + appVersion alignedRelease Flow (after merge)
developdevelopβmainHermes π