fix(ci): use live PR title in feat-minor-bump-gate (#3240)#3242
Merged
Conversation
Contributor
There was a problem hiding this comment.
Approved -- all CI green.
Surgical fix: moved livePr API fetch before title check, pr.title -> livePr.title. Single API call provides both live title and live labels.
This fixes the exact bug that blocked #3222 and #3238. Title renames will now take effect on re-run without force-push.
Bonus: developed through Aegis (dogfooding!).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #3240 —
feat-minor-bump-gatereads frozen webhook title instead of live PR title.Problem
The
feat-minor-bump-gateCI job usespr.titlefrom the frozen webhook payload for theisFeatregex check, while already fetchinglivePrfrom the API for labels. Title renames via GitHub UI or after amend+force-push don't take effect.Fix
Moved the
livePrAPI fetch before the title check and changedpr.title→livePr.title. Single API call now provides both live title and live labels.Impact
Verification
CI workflow changes don't have unit tests — verified by reading the diff. The logic is identical to before except
pr.title→livePr.titleand the API call is moved up.