fix(acp): increase default prompt timeout 60s to 120s for BYO-LLM proxies (#3243)#3244
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Approved — all CI green.
Mechanical timeout bump: 60s → 120s in DEFAULT_REQUEST_TIMEOUT_MS and config default. 8 test files updated with matching inline Config values. 1 new assertion in config.test.ts verifying the default.
Clean follow-up to #3225. The dogfooding gap (CC could not complete within 60s through z.ai proxy) validates the increase. After server restart with 120s, full dogfooding should be viable.
aegis-gh-agent Bot
pushed a commit
that referenced
this pull request
May 12, 2026
PR #3244 increased acpPromptTimeoutMs from 60000 to 120000. Docs still showed the old default. Updates: - docs/enterprise.md: default 60000→120000, 60s→120s - docs/getting-started.md: default 60000→120000
This was referenced May 12, 2026
OneStepAt4time
added a commit
that referenced
this pull request
May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #3243 — ACP prompt delivery timeout still insufficient for BYO-LLM proxies after #3225.
Problem
After increasing JSON-RPC timeout from 15s to 60s in #3225, session creation via API (
POST /v1/sessions) still times out with z.ai/glm-5.1 proxy:The
ag runCLI path works because it uses streaming, but direct API session creation blocks for the full 60s and often fails.Fix
Increase default
acpPromptTimeoutMsfrom 60s to 120s in:src/services/acp/json-rpc-client.ts(DEFAULT_REQUEST_TIMEOUT_MS)src/config.ts(default value)Verification
Next step (separate PR)
Long-term fix: make session creation async (202 + poll) so timeout doesn't block the HTTP response.
Session: Aegis session 3449acf3 (partial) + direct completion
Commit: c780641