Skip to content

fix(acp): increase default prompt timeout 60s to 120s for BYO-LLM proxies (#3243)#3244

Merged
OneStepAt4time merged 1 commit into
developfrom
fix/3243-acp-timeout-120s
May 12, 2026
Merged

fix(acp): increase default prompt timeout 60s to 120s for BYO-LLM proxies (#3243)#3244
OneStepAt4time merged 1 commit into
developfrom
fix/3243-acp-timeout-120s

Conversation

@OneStepAt4time

Copy link
Copy Markdown
Owner

Summary

Fixes #3243 — ACP prompt delivery timeout still insufficient for BYO-LLM proxies after #3225.

Problem

After increasing JSON-RPC timeout from 15s to 60s in #3225, session creation via API (POST /v1/sessions) still times out with z.ai/glm-5.1 proxy:

[ACP prompt timeout] session=aaebbbfd method=session/prompt timeout=60000ms

The ag run CLI path works because it uses streaming, but direct API session creation blocks for the full 60s and often fails.

Fix

Increase default acpPromptTimeoutMs from 60s to 120s in:

  • src/services/acp/json-rpc-client.ts (DEFAULT_REQUEST_TIMEOUT_MS)
  • src/config.ts (default value)
  • 8 test files with inline Config objects

Verification

tsc --noEmit  ✓ (zero errors)
npm run build  ✓ (success)
npm test       ✓ (4084 passed, 1 pre-existing flake in server-core-coverage.test.ts)

Next step (separate PR)

Long-term fix: make session creation async (202 + poll) so timeout doesn't block the HTTP response.

Session: Aegis session 3449acf3 (partial) + direct completion
Commit: c780641

@aegis-gh-agent aegis-gh-agent Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved — all CI green.

Mechanical timeout bump: 60s → 120s in DEFAULT_REQUEST_TIMEOUT_MS and config default. 8 test files updated with matching inline Config values. 1 new assertion in config.test.ts verifying the default.

Clean follow-up to #3225. The dogfooding gap (CC could not complete within 60s through z.ai proxy) validates the increase. After server restart with 120s, full dogfooding should be viable.

@OneStepAt4time OneStepAt4time merged commit 1add189 into develop May 12, 2026
18 checks passed
@OneStepAt4time OneStepAt4time deleted the fix/3243-acp-timeout-120s branch May 12, 2026 12:12
aegis-gh-agent Bot pushed a commit that referenced this pull request May 12, 2026
PR #3244 increased acpPromptTimeoutMs from 60000 to 120000.
Docs still showed the old default.

Updates:
- docs/enterprise.md: default 60000→120000, 60s→120s
- docs/getting-started.md: default 60000→120000
OneStepAt4time added a commit that referenced this pull request May 12, 2026
CHANGELOG entries for: #3244 (ACP timeout 120s), #3249 (ag run client timeout), #3246 (aria i18n batch 3), #3245 (timeout docs), #3248 (troubleshooting note).

Prep for v0.6.7 release.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant