fix(cli): add timeout to ag run session creation fetch (#3247)#3249
Merged
Conversation
Contributor
There was a problem hiding this comment.
Approved — all CI green.
Clean fix: AbortSignal.timeout(120_000) on session creation fetch + AbortError handling with actionable error message.
Root cause analysis is solid — broski hit v0.6.6 which predates ag run entirely. This fix needs v0.6.7 release along with the 120s server-side timeout (#3244).
P1 release blocker resolved client-side. Shipping v0.6.7 is the next critical step.
This was referenced May 12, 2026
OneStepAt4time
added a commit
that referenced
this pull request
May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #3247 —
ag runhangs silently when session creation is slow.Problem
ag runhas no timeout on thePOST /v1/sessionsfetch call. When the server is slow (ACP prompt delivery with BYO-LLM proxies), the client hangs indefinitely with no feedback — exactly what broski hit as our first external tester.Root Cause
Two compounding issues:
handleRun()has noAbortSignal.timeout()— it hangs forever if the server is slowFix
AbortSignal.timeout(120_000)to the session creation fetch callAEGIS_ACP_PROMPT_TIMEOUT_MSImportant note
Broski installed v0.6.6 which does NOT include the
ag runcommand (added after v0.6.6 in #3043). This fix needs to ship in v0.6.7 release along with the 120s server-side timeout (#3243).Verification
tsc --noEmit ✓ npm run build ✓ npm test ✓ (5 pre-existing failures unrelated to this change)Commit: 7dadd32