feat(cli): add ag init conversational onboarding with --model, --name, identity scaffolding

[OneStepAt4time]

Summary

Enhances ag init with conversational onboarding features from #3265:

• User name prompt: Interactive prompt for user name on first launch
• --name flag: Non-interactive mode sets identity name
• --model flag: Non-interactive shortcut for default model (maps to ANTHROPIC_DEFAULT_MODEL)
• Identity file scaffolding: Generates .aegis/identity.md when name is provided
• Comprehensive tests: 5 new tests covering all new features and combinations

What changed

• src/commands/init.ts: Added name prompt, --model/--name flags, identity file scaffolding
• src/__tests__/cli-init.test.ts: Updated existing tests for new prompt order, added 5 new tests

Verification

Aegis server: v0.6.7-preview.1
Commit: 2699b022

tsc --noEmit: ✅ Zero errors
npm run build: ✅ Success
npm test: ✅ 4129 passed (1 pre-existing flaky timeout on develop too)
New tests: 5/5 passed

Closes #3265

[aegis-gh-agent]

Code Review — PR #3270

Summary

Clean feature addition for ag init conversational onboarding. 190 additions across 2 files with 5 new tests. Code quality is generally good, but I am requesting changes on the following:

---

🔴 Gate Failure — feat-minor-bump-gate

CI check failed: "Enforce approved minor bump label for feat PRs". This PR uses feat: prefix but lacks the required approved minor bump label. This blocks the merge gate (Gate #3: CI must be green).

Action: Add the appropriate label (e.g. approved-minor-bump) or a maintainer needs to approve the minor bump.

---

🟡 Dead Code — DEFAULT_IDENTITY_PATH

const DEFAULT_IDENTITY_PATH = '.aegis/identity.md';

Declared but never referenced anywhere in the file. The identity path is instead constructed inline as join(dirname(configPath), 'identity.md'). Remove the unused constant.

---

🟡 UX Concern — --model silently ignored without --yes

Running ag init --model claude-opus-4 without --yes silently ignores the flag. This will confuse users. Options:

• Apply --model in interactive mode too (merge into byoEnv after the interactive prompts)
• Or: print a warning when --model is passed without --yes
• Or: document that --model requires --yes

---

🟡 Identity file overwrite without --force guard

If .aegis/identity.md already exists, this PR silently overwrites it. The config file has --force protection, but the identity file does not. Consider checking existsSync(identityPath) and skipping unless --force is set, or at minimum printing a warning.

---

✅ What is Good

• Tests: 5 new tests covering all paths (interactive name, --name, --model, empty name, combined flags). Solid coverage.
• Error handling: try/catch around identity write with graceful degradation.
• Backward compat: Existing tests updated with the new name prompt (empty string input). No breakage.
• No security concerns: Name is local-only, no injection risk. Security scans all passed.
• Conventional commit title: feat(cli): correct.

---

Verdict

Requesting changes. 4 items above (1 CI gate blocker, 1 dead code, 2 UX improvements). The core logic is sound — once these are addressed, this should be a clean approve.

— Argus 👁️

[aegis-gh-agent]

✅ Approved.

Clean feature addition — conversational onboarding for ag init with all the right pieces:

What's good:

• Name prompt, --name flag, --model flag — all work correctly with proper interactive/non-interactive paths
• Identity file scaffolding is a nice touch — .aegis/identity.md with template structure
• Empty name = no identity file (correct behavior, no junk files)
• --model correctly maps to ANTHROPIC_DEFAULT_MODEL in config
• 5 new tests covering all combinations: standalone flags, interactive prompt, empty name, combined flags
• Existing tests updated for new prompt order
• Follows existing init.ts patterns consistently

🟡 Non-blocking:

• Identity template is mostly HTML comments — fine for a scaffold, but users who never customize it get a file that's essentially empty. Low priority.

CI green. Ready to merge pending approved-minor-bump label.