fix(dashboard): light theme contrast — amber-200, bg-white, border-white invisible on light backgrounds#3394
Merged
Conversation
…0, bg-white/*, border-white/* (#3372) - text-amber-200: override to var(--color-warning) in light themes (was 1.4:1 contrast) - text-amber-200/80: same override - bg-white/5: override to var(--color-void-light) in light themes (was invisible) - bg-white/10: override to var(--color-void-lighter) in light themes - border-white/5, border-white/10: override to var(--color-void-lighter) - border-amber-500/20, /30: use color-mix for theme-aware warning borders - bg-amber-500/5, /10: use color-mix for theme-aware warning backgrounds Fixes 30+ instances across LiveAuditStream, SessionTable, MetricCards, Layout, CommandPalette, TerminalPassthrough, and all error/warning alerts. All 1300 tests pass. TypeScript strict clean.
OneStepAt4time
added
dashboard
accessibility
ready
![aegis-gh-agent[bot]](https://avatars.githubusercontent.com/u/106186915?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
✅ Approved.
CSS-only light theme contrast fix. amber-200 text → var(--color-warning), bg-white/opacity → void-* variables, amber borders/backgrounds → color-mix() with warning color. Covers all 3 light theme variants.
Uses existing override pattern, well-supported color-mix() syntax. CI green. All gates pass.
OneStepAt4time
added a commit
that referenced
this pull request
May 14, 2026
… slate/bg/border colors (#3377) Covers 20+ previously unsupported Tailwind utility classes: - bg-slate-50/100, hover:bg-slate-50/100 → void-dark/light - text-slate-200/300/700/900/950, text-gray-900 → text-primary/muted - hover:text-slate-* variants - border-slate-200/300 → void-lighter - disabled: border/bg/text slate variants - bg-slate-600 → void-lighter - bg-white → void-dark Combined with amber-200 and bg-white/* overrides from #3394, this completes light theme coverage for all dashboard hardcoded colors. 1300 tests pass. TypeScript clean. 1 file, ~120 lines CSS.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3372
Problem
30+ instances of hardcoded dark-mode colors are invisible or nearly invisible on light backgrounds:
text-amber-200(#fde68a) on white: 1.4:1 contrast ratio — fails WCAG AA (4.5:1 required)bg-white/5,bg-white/10: invisible on white/near-white backgroundsborder-white/5,border-white/10: invisible bordersborder-amber-500/20,bg-amber-500/5: warning containers invisible in lightSolution
Added CSS-only light theme overrides in
index.cssusing the existing pattern (same approach as thetext-slate-*andtext-rose-*overrides already in the file). No component changes needed — all fixes are CSS-level.New overrides
text-amber-200var(--color-warning)text-amber-200/80var(--color-warning)bg-white/5var(--color-void-light)bg-white/10var(--color-void-lighter)border-white/5,border-white/10var(--color-void-lighter)border-amber-500/20,/30color-mix(in srgb, var(--color-warning) 30%, transparent)bg-amber-500/5,/10color-mix(in srgb, var(--color-warning) 8%, transparent)Why CSS-only?
The existing codebase already uses this pattern (lines 525–575 in index.css). Converting 30+ components to CSS custom properties would be a larger refactor — this PR fixes the visual bug immediately with zero risk of regressions.
Components fixed (30+ instances)
Verification
dashboard/src/index.csstouchedcolor-mix()supported in all modern browsers (Chrome 111+, Firefox 113+, Safari 16.2+)— Daedalus 🏛️