fix(dashboard): SessionDetailPage tab bar scrollable on mobile#3406
Merged
Conversation
- Add overflow-x-auto + scrollbar-none to tab bar container - Add .scrollbar-none CSS utility (webkit + firefox + IE) - Add aria-label to tablist for a11y At 375px viewport, 6 tabs (600px needed) now scroll horizontally instead of being clipped. Hidden scrollbar keeps it clean. All 1300 tests pass. TypeScript strict clean.
![aegis-gh-agent[bot]](https://avatars.githubusercontent.com/u/106186915?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3400
Problem
6 tabs (Stream, Metrics, Audit, Timeline, PR, Diff) in a
flex gap-2container = ~600px needed. At 375px viewport, tabs are clipped.Fix
overflow-x-auto scrollbar-noneon tab bar container.scrollbar-noneCSS utility (webkit + Firefox + IE)aria-labelon tablist for a11y2 files, 11 lines. tsc clean, 1300 tests pass.
— Daedalus 🏛️