Skip to content

Commit 0e0274c

Browse files
committed
Merge "Change Farore's Wind Text to Display Full Dungeon Names (inc Tower)" (#2518)
# Conflicts: # ASM/build/asm_symbols.txt # ASM/build/bundle.o # ASM/build/c_symbols.txt # data/generated/patch_symbols.json # data/generated/rom_patch.txt # data/generated/symbols.json
2 parents cd68fac + acf5c68 commit 0e0274c

11 files changed

Lines changed: 38319 additions & 37932 deletions

File tree

ASM/build/asm_symbols.txt

Lines changed: 730 additions & 730 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

ASM/build/bundle.o

1.55 KB
Binary file not shown.

ASM/build/c_symbols.txt

Lines changed: 711 additions & 711 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

ASM/c/dungeon_info.c

Lines changed: 85 additions & 47 deletions
Large diffs are not rendered by default.

ASM/c/dungeon_info.h

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,8 @@ typedef struct {
1313
uint8_t has_map : 1;
1414
};
1515
uint8_t skulltulas;
16-
char name[11];
16+
char short_name[11];
17+
char name[22];
1718
uint8_t silver_rupee_puzzles_vanilla[4];
1819
uint8_t silver_rupee_puzzles_mq[4];
1920
} dungeon_entry_t;
@@ -25,7 +26,7 @@ typedef struct {
2526
} boss_entry_t;
2627

2728
extern int dungeon_count;
28-
extern dungeon_entry_t dungeons[14];
29+
extern dungeon_entry_t dungeons[15];
2930

3031
void draw_dungeon_info(z64_disp_buf_t* db);
3132
void draw_world_info(z64_disp_buf_t* db);

ASM/c/message.c

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -187,6 +187,11 @@ bool Message_Decode_Additional_Control_Codes(uint8_t currChar, uint32_t* pDecode
187187
break;
188188
}
189189
case 0x41B:
190+
case 0x427: {
191+
// Ganon's Tower
192+
Message_AddString(msgCtx, pFont, pDecodedBufPos, pCharTexIdx, dungeons[12].name);
193+
break;
194+
}
190195
case 0x467:
191196
case 0x534:
192197
case 0x538:
@@ -195,8 +200,8 @@ bool Message_Decode_Additional_Control_Codes(uint8_t currChar, uint32_t* pDecode
195200
case 0x544:
196201
case 0x548:
197202
case 0x54C: {
198-
// Ganon
199-
Message_AddString(msgCtx, pFont, pDecodedBufPos, pCharTexIdx, dungeons[12].name);
203+
// Ganon's Castle
204+
Message_AddString(msgCtx, pFont, pDecodedBufPos, pCharTexIdx, dungeons[13].name);
200205
break;
201206
}
202207
default: {

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44
* New hint distribution field `boss_goal_names` can be set to `false` to force dungeon reward names to be used for goal text instead of boss names even if dungeon rewards are on bosses.
55
* The `Free Reward from Rauru` has a new `Yes (Forced)` option which forces the check to be a dungeon reward even if these are otherwise shuffled.
66
* The `Maps & Compasses` shuffle setting has been split into separate `Maps` and `Compasses` settings.
7+
* The Farore's Wind text box now distinguishes between Ganon's Castle and Ganon's Tower.
78

89
## Bug fixes
910
* Fix a potential softlock when talking to Pierre (the upper scarecrow) as child in Lake Hylia.

data/generated/patch_symbols.json

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)