Merge 'Replace non-ASCII characters in song names with question marks' (#2222)

Author: fenhl

Cosmetics.py

@@ -989,9 +989,9 @@ def patch_song_names(rom: Rom, settings: Settings, log: CosmeticsLog, symbols: d
             break
         if len(song_name) > 50:
             song_name_cropped = song_name[:50]
-            text_bytes = [ord(c) for c in song_name_cropped]
+            text_bytes = [ord('?' if ord(c) >= 0x80 else c) for c in song_name_cropped]
         else:
-            text_bytes = [ord(c) for c in song_name] + [ord('\0')] * (50 - len(song_name))
+            text_bytes = [ord('?' if ord(c) >= 0x80 else c) for c in song_name] + [ord('\0')] * (50 - len(song_name))
         bytes_to_write += text_bytes
     rom.write_bytes(symbols['CFG_SONG_NAMES'], bytes_to_write)
     log.display_custom_song_names = settings.display_custom_song_names

version.py

@@ -1,4 +1,4 @@
-__version__ = '8.1.57'
+__version__ = '8.1.58'
 
 # This is a supplemental version number for branches based off of main dev.
 supplementary_version = 0