Merge 'Enable overriding rainbow tunics' (#2582)

Author: fenhl

CHANGELOG.md

@@ -5,6 +5,7 @@
 * Fix a vanilla bug where the player can become unable to move when the Hookshot is pulled but fails to load.
 * Fix a bug where the item on the `Song from Saria` location could be obtained multiple times by savewarping on the first frame after obtaining it, then returning to the location.
 * Fix a generator failure when a dungeon reward is selected as a random starting item and the Temple of Time altar is set to hint dungeon reward locations.
+* Fix a bug where overriding cosmetics could not override rainbow tunics.
 
 # 9.1
 

Cosmetics.py

@@ -107,6 +107,10 @@ def patch_tunic_colors(rom: Rom, settings: Settings, log: CosmeticsLog, symbols:
     tunic_color_list = Colors.get_tunic_colors()
     rainbow_error = None
 
+    # Clear all rainbow tunic bits so that it can be overridden.
+    if 'CFG_RAINBOW_TUNIC_ENABLED' in symbols:
+        rom.write_byte(symbols['CFG_RAINBOW_TUNIC_ENABLED'], 0)
+
     for tunic, tunic_setting, address in tunics:
         tunic_option = getattr(settings, tunic_setting)
 

version.py

@@ -1,4 +1,4 @@
-__version__ = '9.1.8'
+__version__ = '9.1.9'
 
 # This is a supplemental version number for branches based off of main dev.
 supplementary_version = 0