Separate settings for Open Deku Tree and Open Forest#1536
Closed
fenhl wants to merge 1 commit into
Closed
Conversation
Collaborator
Author
|
Should probably also rename “Open Forest” to “Open Forest Exit” for clarity. |
cjohnson57
added
Component: Setting
Collaborator
|
I don't really see this setting being worth it due to the difference between closed forest/closed deku and closed forest/open deku being very minute, and it already being a not-much-used setting, sorry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This replaces the single 3-option “Forest” dropdown with 2 separate checkbuttons, making the 4th option of combining Closed Forest with Open Deku Tree possible.
This also allows introducing equivalent
disablerelations to those added in #1531.