Change some location names for consistency with region names#2102
Open
fenhl wants to merge 2 commits into
Open
Change some location names for consistency with region names#2102fenhl wants to merge 2 commits into
fenhl wants to merge 2 commits into
Conversation
Collaborator
|
While this change is objectively good for consistency, I'm not sure it's worth breaking so many plandos and other things over, at this point |
Collaborator
Author
|
Maybe we could add aliases similar to what's proposed for settings in #1839 so the old names keep working. |
Collaborator
|
We discussed changing this so it won't break old plandos while changing the names |
6be3c0f to
0b423ea
Compare
|
Does this allow renaming locations to the same names that other locations used to have? For example if a series of numbered checks, if we decided to change the ordering and renumber them. |
Collaborator
Author
|
No, in that case we wouldn't be able to use the alias system and would have to break old plandos. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #684. All item locations in interiors and grottos now contain the name of the region or scene, allowing easier navigation of spoiler logs. The following names have been changed:
Regions
Locations