Stick/Nut/Magic Upgrade Model Improvements#2313
Merged
Merged
Conversation
fenhl
added
Type: Enhancement
|
It would be nice to have a same effect for magic meter maybe ? |
GSKirox
requested changes
Oct 28, 2024
GSKirox
left a comment
GSKirox
left a comment
Collaborator
There was a problem hiding this comment.
A couple of formatting nitpicks
GSKirox
approved these changes
Jan 6, 2025
cjohnson57
removed
the
Status: Under Consideration
fenhl
added
the
Status: Waiting for Release
fenhl
added
Status: Waiting for Author
rrealmuto
changed the title
Author
|
Updated the magic scroll model with rainbow smoke and removed the glow that was around the jar. What do we want to do for double magic? |
Collaborator
|
I'd say keep the two identical for now and update it if/when we get a separate model? |
fenhl
added
Status: Waiting for Maintainers
and removed
Status: Waiting for Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a flame/smoke effect to the stick/nut upgrade and the new magic scroll GI models as shown below.