Enforce closed forest via item placement and make compatible with ER#2349
Closed
fenhl wants to merge 2 commits into
Closed
Enforce closed forest via item placement and make compatible with ER#2349fenhl wants to merge 2 commits into
fenhl wants to merge 2 commits into
Conversation
This being on unconditionally is the only part I don't really like about this. I understand doing it for newbies as they are always confused by this, and not too many people use the setting otherwise so having a dedicated setting for it would be weird, but maybe there could be some plando flag to enable the old behaviour? |
Collaborator
Author
|
I suppose adding the Require Gohma setting (the other half of #1531) as a plando-only setting could be a good compromise. |
|
"Prevent items that could be used to glitchlessly escape the forest without defeating Queen Gohma from being placed inside the forest area." |
Collaborator
Author
|
We'll go with the option of making it a plando-only setting. I'll adjust #1531 accordingly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is everything in #1531 except for the new setting that allows playing with the forest exit blocked but without the item restrictions. To summarize, this PR modifies closed forest to: