Skip to content

New model for ice traps#2375

Merged
fenhl merged 2 commits into
OoTRandomizer:Devfrom
GSKirox:ice_trap_model
Jun 3, 2025
Merged

New model for ice traps#2375
fenhl merged 2 commits into
OoTRandomizer:Devfrom
GSKirox:ice_trap_model

Conversation

@GSKirox

@GSKirox GSKirox commented Feb 12, 2025

Copy link
Copy Markdown
Collaborator

An attempt to answer #2359

Credits to @Nax for the implementation on OotMM

This implements a new model when Link gets an ice trap from any other source than a chest. This model is derived from one of the objects that draw an ice effect, called gEffIceFragment3DL in decomp.

Here is a video showing how it looks (taken on Dolphin)

2025-02-12.15-22-47.mp4

And an easy plando to test it quickly

  "settings":                  {
    "starting_age":                            "adult",
    "spawn_positions":                         [
      "adult"
    ]
  },
  "entrances":                 {
	"Adult Spawn -> Temple of Time":  {"region":  "Kak Impas Ledge", "from": "Kak Impas House Back"}
  },
  "locations":                 {
    "Kak Anju as Adult":                                      "Ice Trap"
  }
}

@GSKirox GSKirox added Type: Enhancement New feature or request Component: ASM/C Changes some internals of the ASM/C libraries Status: Needs Review Someone should be looking at it Status: Under Consideration Developers are considering whether to accept or decline the feature described labels Feb 12, 2025
@fenhl fenhl added Status: Needs Testing Probably should be tested and removed Status: Under Consideration Developers are considering whether to accept or decline the feature described labels Mar 23, 2025
@fenhl

fenhl commented Mar 23, 2025

Copy link
Copy Markdown
Collaborator

Needs testing for what happens if an ice trap from a pot is picked up, both with major and junk cloak.

@fenhl

fenhl commented Mar 23, 2025

Copy link
Copy Markdown
Collaborator

Also would be nice if we could have the Big Octo cutscene use this (after Ruto picks it up, not while on the platform), but that can be a separate PR.

@GSKirox

GSKirox commented May 21, 2025

Copy link
Copy Markdown
Collaborator Author

After testing, i can confirm freestandings work as expected (show the fake model until it gets picked, then the new model when picked), but the drops from pots/crates/wonderitems still use the fake model.
So i'll work on that while solving the conflicts and updating the branch.

@GSKirox

GSKirox commented May 21, 2025

Copy link
Copy Markdown
Collaborator Author

Rebased on current dev and added code to item_give_collectible so that all Robsanity drops display the new model when picked.

@fenhl fenhl removed Status: Needs Review Someone should be looking at it Status: Needs Testing Probably should be tested labels Jun 3, 2025
@fenhl fenhl added this to the next milestone Jun 3, 2025
@fenhl fenhl merged commit 52cdeaa into OoTRandomizer:Dev Jun 3, 2025
3 checks passed
@GSKirox GSKirox deleted the ice_trap_model branch June 9, 2025 06:15
@fenhl fenhl linked an issue Jul 17, 2025 that may be closed by this pull request
@fenhl fenhl mentioned this pull request Jul 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Component: ASM/C Changes some internals of the ASM/C libraries Type: Enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Custom Ice Trap Models

2 participants