New model for ice traps#2375
Merged
Merged
Conversation
Collaborator
|
Needs testing for what happens if an ice trap from a pot is picked up, both with major and junk cloak. |
Collaborator
|
Also would be nice if we could have the Big Octo cutscene use this (after Ruto picks it up, not while on the platform), but that can be a separate PR. |
Collaborator
Author
|
After testing, i can confirm freestandings work as expected (show the fake model until it gets picked, then the new model when picked), but the drops from pots/crates/wonderitems still use the fake model. |
Collaborator
Author
|
Rebased on current dev and added code to item_give_collectible so that all Robsanity drops display the new model when picked. |
fenhl
approved these changes
Jun 3, 2025
Closed
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An attempt to answer #2359
Credits to @Nax for the implementation on OotMM
This implements a new model when Link gets an ice trap from any other source than a chest. This model is derived from one of the objects that draw an ice effect, called gEffIceFragment3DL in decomp.
Here is a video showing how it looks (taken on Dolphin)
2025-02-12.15-22-47.mp4
And an easy plando to test it quickly