Allow big poe soul collect on Epona#2377
Merged
Merged
Conversation
GSKirox
added
Type: Enhancement
|
Potential scenario, all of your bottles are full and then you run into it accidentally when you meant to get off and dump a bottle. |
Skill issue. Can do the same thing as just Link. |
Collaborator
Author
|
It's actually kinda hard to do it accidentally since you have to stop Epona on top of it |
fenhl
removed
the
Status: Under Consideration
rrealmuto
suggested changes
May 12, 2025
rrealmuto
left a comment
rrealmuto
left a comment
There was a problem hiding this comment.
This looks good other than the one comment I made.
Collaborator
Author
|
Implemented Rob's suggestion by using 0x34(sp) to grab Playstate |
Collaborator
|
Rob says this looks good from the review side. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small QoL change to allow collecting a big poe soul while still riding Epona.
The collider of the soul actor has been changed to interact with anything that has an appropriate collider, but there is also additional protection to ensure that only either Link, or Epona when Link is riding, will trigger the textbox.
2025-02-20.18-53-33.mp4