Maybe fix race condition with archive file#2389
Merged
Merged
Conversation
cjohnson57
added
Type: Bug
Collaborator
|
What needs to happen for this to come out of the draft stage? |
fenhl
added
Status: Waiting for Maintainers
and removed
Status: Waiting for Author
rrealmuto
suggested changes
Nov 30, 2025
There was a problem hiding this comment.
This new compressor routine looks like it properly addresses the previous race condition. My only concern is regarding changing the format of the ARCHIVE.bin file which will invalidate existing ARCHIVE.bin files and prevent the compressor from working correctly until the file is deleted. This mostly affects developers who will likely be using the same ARCHIVE.bin file across multiple branches checked out w/ git. I proposed a few recommendations to address this which I suggest we do before merging.
Other than just just a few minor cleanup things.
Co-authored-by: rrealmuto <rrealmuto@gmail.com>
Some additional compressor fixes.
cjohnson57
approved these changes
Dec 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update how we're handling archive files in the compressor, tie the archive data to the dma table entry instead of just relying on a number being incremented.