Skip to content

Fix misc. location hints not being counted as always hints#2391

Merged
fenhl merged 3 commits into
OoTRandomizer:Devfrom
fenhl:fix-bingo-always-hints
Nov 26, 2025
Merged

Fix misc. location hints not being counted as always hints#2391
fenhl merged 3 commits into
OoTRandomizer:Devfrom
fenhl:fix-bingo-always-hints

Conversation

@fenhl

@fenhl fenhl commented Mar 20, 2025

Copy link
Copy Markdown
Collaborator

This fixes 2 bugs:

  • Allow foolish hints for areas with always hints but not other hint types #1443 allowed Barren hints to generate for hint areas with Always or Dual Always hints (e.g. DMT if Biggoron is an Always hint). This PR allows the same for hint areas with misc. location hints (e.g. Kakariko if skull house hints are on).
  • Similarly, the mechanism to prevent a generator crash when a named_items_required Named Item hint conflicts with an Always or Dual Always hint is now extended to misc. location hints. This reduces the failure rate of the SDG Bingo Tournament 3 preset on my branch from 1578/16384 to 12/16384.

@fenhl fenhl added Type: Bug Something isn't working Status: Needs Review Someone should be looking at it Component: Hints related to how we help the player labels Mar 20, 2025
@fenhl fenhl force-pushed the fix-bingo-always-hints branch from a797ead to fa8f63e Compare November 25, 2025 22:33
@fenhl fenhl removed the Status: Needs Review Someone should be looking at it label Nov 26, 2025
@fenhl fenhl added this to the next milestone Nov 26, 2025
@fenhl fenhl merged commit ad46d9f into OoTRandomizer:Dev Nov 26, 2025
6 checks passed
@fenhl fenhl deleted the fix-bingo-always-hints branch November 26, 2025 02:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Component: Hints related to how we help the player Type: Bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants