More options for “Open Door of Time” setting#2423
Merged
Merged
Conversation
|
I think this affects settings which don't use the new dot options by not allowing ocarina 2 to ever be foolish? |
Collaborator
Author
|
The PR includes a change to |
|
I didn't know we actually already had something like this for big poes and wallets. |
Collaborator
Author
This is now fixed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This replaces the “Open Door of Time” checkbutton setting with a “Door of Time” combobox with the options listed at #1471 (comment).
Somewhat confusing: If you play Song of Time in front of the altar without the necessary items (OoT and/or stones, depending on the selected option), the door doesn't open but you still get the Secret sound effect and a brief cutscene camera. Maybe we could instead have Navi remind you about the setting. Not sure if that should be considered a blocker for this PR though, it would require a cutscene hack if I understood correctly.
Special thanks to @rrealmuto for showing me how to identify the address to hack. I've included a brief summary of what I learned in a new file in the
Notesdirectory, though a more complete guide would still be nice to have eventually.Closes #1471.