Skip to content

More options for “Open Door of Time” setting#2423

Merged
fenhl merged 6 commits into
OoTRandomizer:Devfrom
fenhl:dot-conditions
Jul 29, 2025
Merged

More options for “Open Door of Time” setting#2423
fenhl merged 6 commits into
OoTRandomizer:Devfrom
fenhl:dot-conditions

Conversation

@fenhl

@fenhl fenhl commented May 19, 2025

Copy link
Copy Markdown
Collaborator

This replaces the “Open Door of Time” checkbutton setting with a “Door of Time” combobox with the options listed at #1471 (comment).

Somewhat confusing: If you play Song of Time in front of the altar without the necessary items (OoT and/or stones, depending on the selected option), the door doesn't open but you still get the Secret sound effect and a brief cutscene camera. Maybe we could instead have Navi remind you about the setting. Not sure if that should be considered a blocker for this PR though, it would require a cutscene hack if I understood correctly.

Special thanks to @rrealmuto for showing me how to identify the address to hack. I've included a brief summary of what I learned in a new file in the Notes directory, though a more complete guide would still be nice to have eventually.

Closes #1471.

@fenhl fenhl added Type: Enhancement New feature or request Status: Help Wanted Extra attention is needed Component: Logic Non-trivial changes to the JSON logic files Component: ASM/C Changes some internals of the ASM/C libraries Status: Needs Review Someone should be looking at it Component: Setting specific to setting(s) Component: Hints related to how we help the player Component: Patching Affects the patching of the ROM Component: Documentation Affects user-facing help messages or public API docs labels May 19, 2025
@r0bd0g

r0bd0g commented May 19, 2025

Copy link
Copy Markdown

I think this affects settings which don't use the new dot options by not allowing ocarina 2 to ever be foolish?

@fenhl

fenhl commented May 19, 2025

Copy link
Copy Markdown
Collaborator Author

The PR includes a change to max_progressive in World.py to avoid that.

@r0bd0g

r0bd0g commented May 19, 2025

Copy link
Copy Markdown

I didn't know we actually already had something like this for big poes and wallets.

@fenhl

fenhl commented Jul 29, 2025

Copy link
Copy Markdown
Collaborator Author

Somewhat confusing: If you play Song of Time in front of the altar without the necessary items (OoT and/or stones, depending on the selected option), the door doesn't open but you still get the Secret sound effect and a brief cutscene camera.

This is now fixed.

@fenhl fenhl removed the Status: Needs Review Someone should be looking at it label Jul 29, 2025
@fenhl fenhl added this to the next milestone Jul 29, 2025
@fenhl fenhl merged commit 3c1fba1 into OoTRandomizer:Dev Jul 29, 2025
3 checks passed
@fenhl fenhl deleted the dot-conditions branch August 23, 2025 04:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Component: ASM/C Changes some internals of the ASM/C libraries Component: Documentation Affects user-facing help messages or public API docs Component: Hints related to how we help the player Component: Logic Non-trivial changes to the JSON logic files Component: Patching Affects the patching of the ROM Component: Setting specific to setting(s) Status: Help Wanted Extra attention is needed Type: Enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Expand "Open Door of Time" setting to allow different requirements

3 participants