Fix finding letter in Kak not completing the mask quest.#2446
Merged
Conversation
rrealmuto
force-pushed
the
zeldas_letter_fix
branch
from
5ef4805 to
ec319ab
Compare
fenhl
added
Type: Bug
GSKirox
approved these changes
Aug 16, 2025
fenhl
approved these changes
Aug 16, 2025
fenhl
removed
Status: Needs Review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is a bug in the GI function for zelda's letter such that if you find letter in Kak it will not properly open the Happy Mask Shop and letter won't be marked off in the new child trade quest scene flags. This bug was introduced in 93a7399 with the changes to automatically open the gate if letter was found in Kak, due to it improperly returning after opening the gate.