Skip to content

Change Important Check Hint Behavior #2447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fenhl merged 5 commits into from
Sep 23, 2025
Merged

Change Important Check Hint Behavior #2447

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ff1afed
exclude hint areas with unshuffled checks
jdunn596 Aug 18, 2025
39b6760
prevent pre-completed dungeons from being hinted
jdunn596 Aug 18, 2025
2d58c76
allow filler hints if no available locations
jdunn596 Aug 24, 2025
bca868c
remove doubled color tag
jdunn596 Aug 24, 2025
df4b1b4
code review
jdunn596 Aug 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions Hints.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1145,11 +1145,16 @@ def get_junk_hint(spoiler: Spoiler, world: World, checked: set[str]) -> HintRetu

def get_important_check_hint(spoiler: Spoiler, world: World, checked: set[str]) -> HintReturn:
top_level_locations = []
empty_dungeons = [dungeon for dungeon in world.precompleted_dungeons if world.precompleted_dungeons[dungeon]]
for location in world.get_filled_locations():
if (HintArea.at(location).text(world.settings.clearer_hints) not in top_level_locations
and (HintArea.at(location).text(world.settings.clearer_hints) + ' Important Check') not in checked
and HintArea.at(location) != HintArea.ROOT):
and HintArea.at(location) != HintArea.ROOT
and HintArea.at(location).dungeon_name not in empty_dungeons # prevent pre-completed dungeons from being hinted
and not location.locked): # prevent areas with unshuffled checks from being hinted
top_level_locations.append(HintArea.at(location).text(world.settings.clearer_hints))
if not top_level_locations:
return None
hint_loc = random.choice(top_level_locations)
item_count = 0
for location in world.get_filled_locations():
Expand Down Expand Up @@ -1188,7 +1193,7 @@ def get_important_check_hint(spoiler: Spoiler, world: World, checked: set[str])
else:
numcolor = 'Green'

return GossipText('#%s# has #%d# major item%s.' % (hint_loc, item_count, "s" if item_count != 1 else ""), ['Green', numcolor]), None
return GossipText('%s has #%d# major item%s.' % (hint_loc, item_count, "s" if item_count != 1 else ""), ['Green', numcolor]), None


hint_func: dict[str, HintFunc | BarrenFunc] = {
Expand Down