Bugfix for Blue Fire Arrows not being taken into account for the logic when starting with them#2461
Merged
fenhl merged 5 commits intoSep 19, 2025
Conversation
…count for logic when having Ice Arrows as a starting item with Blue Fire Arrows enabled.
merge dev
cjohnson57
added
Type: Bug
Collaborator
|
This should probably do it, have you debugged the code in some way to ensure |
fenhl
requested changes
Sep 19, 2025
fenhl
added
Status: Waiting for Author
Author
Here's a screenshot of the inspection of the starting_items object |
…le if/else checks.
…/Echopixel/OoT-Randomizer-Echopixel into bugfix/starting_blue_fire_arrows
fenhl
approved these changes
Sep 19, 2025
fenhl
added
Status: Waiting for Release
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My attempt at a fix for #2172. Not 100% on the change being all that's needed, but I put the logic just in
resetin Plandomizer.py and it seems to be reflected inconfigure_effective_starting_itemsas well as being collected byworld.distribution.collect_starters(world.state)