Bugfix: Can Buy Blue Potion without Showing Odd Mushroom#2462
Merged
Conversation
fenhl
added
Type: Bug
Collaborator
|
Quick note for future PRs: If you include the exact words “fixes #2347” in the PR description, GitHub will automatically link this PR to the issue the way I just did. |
fenhl
approved these changes
Sep 21, 2025
Author
AH, gotcha, thanks. Will do from now on. 👍 |
Collaborator
To clarify, are you saying you've already tested this fix? |
Author
I tested when you have no trade item, when you do have a trade item and when you trade the odd mushroom. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not much to add, might be a better way to do this since I'm not super knowledgeable about ASM/C, was mostly curious how this side of the rando functioned and interested in learning more if anyone is willing to teach me or has good resources. From what I could tell this change has fixed the issue reported by #2347.