Skip to content

Fix Randomized Starting Items#2485

Merged
fenhl merged 2 commits into
OoTRandomizer:Devfrom
jdunn596:random-starting-items-fix
Nov 16, 2025
Merged

Fix Randomized Starting Items#2485
fenhl merged 2 commits into
OoTRandomizer:Devfrom
jdunn596:random-starting-items-fix

Conversation

@jdunn596

Copy link
Copy Markdown

Fixes #2484

Also addresses a bug where "Buy" item events were considered as valid items to be selected. We now exclude those items by filtering the "Shop" type.

Testing

Rolled multiple seeds to ensure the correct ammo amount was added for the affected items and confirmed in-game as well.

@flagrama

Copy link
Copy Markdown

Why is this not the same as non-randomized starting items in the first place? Wouldn't handling this in the Plandomizer.py file like non-randomized starting items make sense too, so someone could turn it off via plando?

@jdunn596

Copy link
Copy Markdown
Author

For turning it on/off yeah maybe? idk

It made sense for us to handle it in ItemPool.py to give easy access to the entire pool for flexibility and versatility regardless of settings. The exclusions were added afterwards for further flexibility

@fenhl fenhl added Type: Bug Something isn't working Component: Algorithm Search, Fill, Playthrough, etc Status: Needs Review Someone should be looking at it labels Nov 12, 2025
Comment thread ItemPool.py Outdated
@fenhl fenhl added the Status: Waiting for Author Changes or response requested label Nov 12, 2025
@jdunn596 jdunn596 requested a review from fenhl November 12, 2025 22:35
@fenhl fenhl removed Status: Waiting for Author Changes or response requested Status: Needs Review Someone should be looking at it labels Nov 13, 2025
@fenhl fenhl added this to the next milestone Nov 16, 2025
@fenhl fenhl merged commit e6fc843 into OoTRandomizer:Dev Nov 16, 2025
6 checks passed
@jdunn596 jdunn596 deleted the random-starting-items-fix branch November 29, 2025 01:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Component: Algorithm Search, Fill, Playthrough, etc Type: Bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Randomized Starting Items Not Starting With Ammo

3 participants