Fix Randomized Starting Items#2485
Merged
Merged
Conversation
|
Why is this not the same as non-randomized starting items in the first place? Wouldn't handling this in the Plandomizer.py file like non-randomized starting items make sense too, so someone could turn it off via plando? |
Author
|
For turning it on/off yeah maybe? idk It made sense for us to handle it in |
fenhl
requested changes
Nov 12, 2025
fenhl
approved these changes
Nov 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2484
Also addresses a bug where "Buy" item events were considered as valid items to be selected. We now exclude those items by filtering the "Shop" type.
Testing
Rolled multiple seeds to ensure the correct ammo amount was added for the affected items and confirmed in-game as well.