Add water hop to morpha and compass chest + MQ

[dotzo]

Adding the new water hop tech to advanced logic. The damage check for the compass chest in vanilla water is to give a little leniency on damage with the stingers without requiring additional items. Essentially takes the trick out of logic for ohko and quad damage.

[jdunn596]

lgtm, failures look like typical ER failures

[shirosoluna]

@fenhl was there something needed for this still?

[fenhl]

It still needs to be formally accepted by the dev team since it's an enhancement (new feature), we haven't gone through the enhancements under consideration in a while, I'll see if I can get that process rolling again, thanks for the reminder.

[fenhl]

It also still needs to be tested. Would be nice to get a pair of plandos showing that the logic works as expected (e.g. using gen success with the trick and failure without, or a difference in woth items).

[dotzo]

waterhoptest.json
Plando attached. 2 required triforce pieces, no hookshots on the world, beatable only, triforces are on water compass chest and one of the pots before morpha. Above fails because no water hop, add water hop to trick list and it works. MQ was copy/pasted from vanilla, so no changes.

Can you also clarify what you mean by "accepted by the dev team"? I thought since we're on our own feature that no one else maintains it was our discretion as to what gets added, and as such the PR in and of itself is approval by the dev team for advanced logic.

[fenhl]

“The dev team” refers to the people with the “Dev Team” Discord role. We currently don't have a formal code owner system.

[dotzo]

I'm still confused. I get there's very few people who do dev work and PRs are a big effort, especially in large numbers, but it's coming off as though the dev team can just decide not to allow something, despite no one on the team having anything to do with the PR itself. Which I could understand if it's an entire feature, but we're just expanding on what's already there, and will continue to do so as more things are found and can be added.

[jdunn596]

Well they can if it doesn't fit the philosophy of the project owners. The dev team is still responsible for any change to Main regardless of whether anyone on the team actively contributes to it because they maintain, bundle, and ship the product as a whole.

As you see with gameplay modes such as TFB, those kind of changes are managed on the respective forks to maintain control

[dotzo]

I get that to some degree on larger projects. Like if advanced logic were rejected as a whole, I'd understand it more than having this same conversation about a single trick to be added to the already vetted logic.