Skip to content

Account For Random Starting Items When Building Misc Hints#2503

Merged
cjohnson57 merged 3 commits into
OoTRandomizer:Devfrom
jdunn596:misc_hint_fix
Apr 4, 2026
Merged

Account For Random Starting Items When Building Misc Hints#2503
cjohnson57 merged 3 commits into
OoTRandomizer:Devfrom
jdunn596:misc_hint_fix

Conversation

@jdunn596

@jdunn596 jdunn596 commented Dec 27, 2025

Copy link
Copy Markdown

Fixes #2502

If you want it formatted differently or something let me know since I know \ is frowned upon

EDIT: Now using paren syntax

Testing

Monitored text output in debugger. Unable to test in-game due to the current compressor issue

@fenhl fenhl added Type: Bug Something isn't working Status: Needs Review Someone should be looking at it Component: Hints related to how we help the player Status: Needs Testing Probably should be tested labels Dec 27, 2025
@jdunn596

jdunn596 commented Dec 27, 2025

Copy link
Copy Markdown
Author

Update: Tested both cases from the reported issue on PJ64 with the debug menu

Screenshot 2025-12-27 155732 Screenshot 2025-12-27 155807

@flagrama

Copy link
Copy Markdown

If you want it formatted differently or something let me know since I know \ is frowned upon

Using parenthesis around the condition is the way it is done (forced) in other languages

@fenhl fenhl removed the Status: Needs Testing Probably should be tested label Dec 27, 2025
@jdunn596

jdunn596 commented Dec 27, 2025

Copy link
Copy Markdown
Author

If you want it formatted differently or something let me know since I know \ is frowned upon

Using parenthesis around the condition is the way it is done (forced) in other languages

Yeah I had it wrapped in parenthesis originally but it just looked stupid to me 😂 can definitely change it back though

Edit: nvm I'm just gonna change it to the use paren

@fenhl

fenhl commented Feb 3, 2026

Copy link
Copy Markdown
Collaborator

Any reason to do it this way instead of just adding randomized_starting_items to effective_starting_items?

@jdunn596

jdunn596 commented Feb 3, 2026

Copy link
Copy Markdown
Author

Any reason to do it this way instead of just adding randomized_starting_items to effective_starting_items?

I couldn't think of a clean way to address the conflicting data types. effective_starting_items is a dict of items and StarterRecord objects whereas randomized_starting_items contains the items and int values making the method of collection different which complicates things

@cjohnson57 cjohnson57 removed the Status: Needs Review Someone should be looking at it label Feb 18, 2026
@cjohnson57 cjohnson57 merged commit ef3cbfd into OoTRandomizer:Dev Apr 4, 2026
6 checks passed
@cjohnson57 cjohnson57 added this to the next milestone Apr 4, 2026
@jdunn596 jdunn596 deleted the misc_hint_fix branch April 5, 2026 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Component: Hints related to how we help the player Type: Bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Misc hints not working with random starting items.

4 participants