Fix Starting Health in SaveContext#2515
Merged
Merged
Conversation
flagrama
approved these changes
Jan 5, 2026
fenhl
approved these changes
Jan 5, 2026
fenhl
added
Type: Bug
GSKirox
approved these changes
Jan 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2514
After a discussion in #dev-bug-reports (thanks @flagrama @GSKirox, @aofengen) we've uncovered the issue where starting health was miscalcuated due to a bug in determining how much health to add relative to the number of currently collected heart pieces in save context. This change corrects this miscalcuation, while also updating the mask value to mirror decomp
Testing
Rolled a few seeds with a bunch of starting health items, both Pieces of Heart and Heart Containers, and observed the health value written to save context during generation. Also tested in-game to make sure the correct health value was written.