Hookshot and Climb Anywhere

[mracsys]

Implements two features under one setting:

1. Hookshot and Longshot can attach to any surface.
2. All wall-type surfaces are made climbable.

Logic is not currently implemented for either Glitchless or Advanced. I'm looking for someone willing to put that together, including base development, trick development, and review responses. I personally don't have the time or interest.

Testing

Worked as expected back on 7.1.

There is a quirk with doors where getting too close to a door will make you start climbing it, when you probably want to open it instead. The feature doesn't prevent opening doors.

[djevangelia]

There is a quirk with doors where getting too close to a door will make you start climbing it, when you probably want to open it instead. The feature doesn't prevent opening doors.

I looked a bit at the climbing following this and have some ideas. (I did this in decomp by editing the walltypes in the array D_80119D90 which looks like what you did?)

You can let player open doors while climbing on them by adding this in the beginning of Player_Action_Climb (Player_Action_8084BF1C). Player cannot try opening doors if not close to one, so it is safe. Player falls down when opening sliding door but stays up in the air for normal doors, so I set new Y position. That could be limited to normal doors only by checking player->doorType.

if (Player_ActionHandler_1(this, play)) {
        this->actor.world.pos.y = this->doorActor->world.pos.y;
        return;
}

Doors have a Y check whether to allow opening, checked by EnDoor_Idle for normal doors and DoorShutter_GetPlayerDistance for sliding doors. For sliding doors the range is set depending on type of door. Y range of 50.0f seems good for normal-size doors to let player open at top of it.

Climbing up on non-horizontal edges doesn't have climb up animation because the game thinks player is not on the ground the frame after going into climb up action. So considering the game assumes player climbing up is on the ground, I added this to the end of Player_ProcessSceneCollision, which makes the animation play:

if (this->actionFunc == Player_Action_ClimbUp) { // Player_Action_8084BDFC
        this->actor.bgCheckFlags |= BGCHECKFLAG_GROUND;
}