Skip to content

Remove FTR and Tunic checks from Bolero>Fire#2545

Merged
cjohnson57 merged 5 commits into
OoTRandomizer:Devfrom
DuskTheUmbreon:patch-8
Apr 4, 2026
Merged

Remove FTR and Tunic checks from Bolero>Fire#2545
cjohnson57 merged 5 commits into
OoTRandomizer:Devfrom
DuskTheUmbreon:patch-8

Conversation

@DuskTheUmbreon

Copy link
Copy Markdown

It makes very little sense that child can be required to enter fire temple's entrance to pick up a tunic for adult to use that entrance, despite it objectively being harder for child to use this entrance than adult, due to the slower speed.

This requires child to have FTR enabled to logically use this entrance. It also slightly simplifies the way the logic is written.

This is a draft PR because I literally wrote this in 5 minutes before work, and I still need to check the rest of the repository for changes that need to accompany it. I also need to add in a parenthesis I just noticed I missed (but can't easily change from right here and don't have time to change right now).

Testing

I didn't test anything yet. I'll download a copy tonight to make the change, I just wanted to actually get this made so I didn't keep forgetting.

It makes very little sense that child can be required to enter fire temple's entrance to pick up a tunic for adult to use that entrance, despite it objectively being harder for child to use this entrance than adult, due to the slower speed.

This requires child to have FTR enabled to logically enter.
@fenhl fenhl added Type: Enhancement New feature or request Status: Waiting for Author Changes or response requested Component: Logic Non-trivial changes to the JSON logic files Status: Needs Review Someone should be looking at it Status: Needs Testing Probably should be tested Status: Under Consideration Developers are considering whether to accept or decline the feature described labels Mar 31, 2026
@r0bd0g

r0bd0g commented Apr 1, 2026

Copy link
Copy Markdown

Opening this dungeon for child was done to increase the options for where dungeons could be placed, particularly under all locations reachable. Locking child access behind the enabling of a trick for the most part defeats the purpose of opening that dungeon for child, locking it off again except for the few players experienced enough to enable the trick. Your logic as written has two issues. First, you have a bracket imbalance that will completely break glitchless logic, easy fix though. Second, you have allowed child in if the Goron Tunic is obtained, which makes no sense, because child cannot wear the Goron Tunic.

@r0bd0g

r0bd0g commented Apr 1, 2026

Copy link
Copy Markdown

If you insist on changing something, instead allow Adult to access the dungeon entrance without the tunic, if adult can enter from the Bolero warp pad. Crater's confusing so without going over it again I'm not sure if that's easy or hard to implement.

@flagrama

flagrama commented Apr 1, 2026

Copy link
Copy Markdown

@r0bd0g

r0bd0g commented Apr 1, 2026

Copy link
Copy Markdown

Alright. I've known about this inconsistency for a long time but as far as I knew it was intentional. It is in my notes as something to potentially change, but it's in the crater rework section of my notes, which is a complicated section in my notes lol, so it got overlooked as something maybe needing more urgent attention. (My notes list a bunch of other things in crater that could be viewed as having mildly inconsistent logic, just stuff that's maybe slightly too hard or slightly too easy for the level of tunic logic currently required.)

I looked it over and I think you can just change the central local->fire entrance logic to just adult or dungeon er. (Boulder shuffle branches would want to be a bit careful while merging this since they'll have slightly more complicated logic here.)

As discussed in the discord, the original intent was to NOT have tunic checked for. The fact that it was turned out to be a mistake all along, caused by some weird merge nonsense.
@DuskTheUmbreon DuskTheUmbreon changed the title Require FTR for child to enter fire temple Remove FTR and Tunic checks from Bolero>Fire Apr 1, 2026
@DuskTheUmbreon

Copy link
Copy Markdown
Author

Changes made. It now instead never checks for tunic or FTR for bolero>fire temple. I also made sure to update advanced logic and the trick list.

Still left in draft because I need to make sure it runs. Currently I'm not able to launch the randomizer at all though, so I need to sort that out first.

Also yes, boulder shuffle will need to be a bit careful here.

@r0bd0g

r0bd0g commented Apr 1, 2026

Copy link
Copy Markdown

FTR is still sometimes used to enter Fire Temple. Instead of removing the line about entering Fire as adult from the tooltip, perhaps add, "without direct access to the Bolero warp pad," or something along those lines?

@fenhl fenhl added Type: Bug Something isn't working and removed Type: Enhancement New feature or request Status: Under Consideration Developers are considering whether to accept or decline the feature described labels Apr 1, 2026
@DuskTheUmbreon

Copy link
Copy Markdown
Author

Ran a test and it worked fine. Just need to sort out the exact language for the trick now.

FTR still applies when coming from local
@DuskTheUmbreon DuskTheUmbreon marked this pull request as ready for review April 2, 2026 03:44
@fenhl fenhl removed Status: Waiting for Author Changes or response requested Status: Needs Testing Probably should be tested labels Apr 2, 2026

@cjohnson57 cjohnson57 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wording seems good to me and I definitely prefer this version of the change.

@cjohnson57 cjohnson57 removed the Status: Needs Review Someone should be looking at it label Apr 4, 2026
@cjohnson57 cjohnson57 merged commit dfd1d41 into OoTRandomizer:Dev Apr 4, 2026
6 checks passed
@cjohnson57 cjohnson57 added this to the next milestone Apr 4, 2026
@DuskTheUmbreon DuskTheUmbreon deleted the patch-8 branch April 26, 2026 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Component: Logic Non-trivial changes to the JSON logic files Type: Bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants