Fix drawing ice encasing when using Bunny Hood/hovering#2555
Merged
Conversation
fenhl
approved these changes
May 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Call
Matrix_Push()andMatrix_Pop()when drawing Bunny Hood ears and Hover Boots hover. Fixes #687.Bunny Hood ears and Hover Boots hover use the current matrix to do calculations, but do not remove the resulting matrix. Drawing the ice encasing when frozen is done after ears and hover drawing.
Thus, the ice will be drawn using the new modified matrix, which causes it to become very huge.
Matrix_Push()pushes a new copy of the current matrix onto the stack andMatrix_Pop()removes the matrix on top of the stack.So by calling these functions before and after the matrix calculations, the ear and hover matrices do not disturb the ice drawing.
Testing
Tested in Ares 1.47, Project64 3.0.1 and Mupen64plus 2.8.
Looks like this: https://www.youtube.com/watch?v=12DBQSBTdV0
To test Hover Boots I called this decomp function, which handles damage and hit response and is the function that sets player frozen.
hitResponseType3 is frozen hit.