Enable setting DEBUG_MODE for C through build.py#2572
Merged
Conversation
GSKirox
added
Component: ASM/C
fenhl
approved these changes
May 9, 2026
fenhl
added
Status: Waiting for Release
fenhl
removed
the
Status: Waiting for Release
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DEBUG_MODEis defined in debug.h and must be manually changed in the file when switching between debug and non-debug build. It's tedious and tampers with the file. It would be helpful to be able to change when building.Here, by running build.py --debug-c,
DEBUG_MODEis set to 1 in the Makefile, so the C is compiled withDEBUG_MODEset. IfDEBUG_MODEisn't externally defined, it is still defined as 0 by debug.h.Testing
I compiled with and without --debug-c with the vanilla build.py and Makefile as far as I could (I need some changes to compile with my compiler).