Skip to content

Shorten crash debugger button code to first combo L+R+Z#2574

Open
djevangelia wants to merge 1 commit into
OoTRandomizer:Devfrom
djevangelia:faultlrz
Open

Shorten crash debugger button code to first combo L+R+Z#2574
djevangelia wants to merge 1 commit into
OoTRandomizer:Devfrom
djevangelia:faultlrz

Conversation

@djevangelia

Copy link
Copy Markdown

This shortens the button sequence to show the crash debugger to the first combination only, L + R and Z.

My reasoning is that not every player wants to get a sudden big ugly scary crash screen if they crash, yet might need to easily open it for a bug report (I will admit I have never been able to successfully enter the full code), and anyone who needs instant screen for debugging purposes can nop the jumps to Fault_WaitForButtonCombo themselves.

The downside could be that sometimes some emulators don't seem to display the yellow crash bar (which could make instant screen better), but if the combo is easy and players know about it, I think they'll try it out on crashing anyways if interested in bug reporting.

Testing

Tested in Ares recent nightly build and Project64 3.0.1.
https://www.youtube.com/watch?v=GmMi43YtEiM

One way to test quickly is to change this code in hacks.asm:

jal     Actor_Spawn_Malloc_Hack
sw      v1, 0x004C(sp)

Test usual crash: Change sw v1,... to sb v1,...
Test HungUp: Change everything to

move a0,zero
jal Fault_AddHungupAndCrashImpl
move a1,zero

@fenhl fenhl added Component: ASM/C Changes some internals of the ASM/C libraries Status: Needs Review Someone should be looking at it Type: Maintenance Code style, infrastructure, updating dependencies labels May 12, 2026
@flagrama

Copy link
Copy Markdown

Honestly, it'd be best to remove the combination entirely and just bring it up right away. People never realize there is a debugger and don't include it in bug reports because they don't know about it.

@fenhl

fenhl commented May 12, 2026

Copy link
Copy Markdown
Collaborator

Agreed. A crash means something has already gone very wrong, so I wouldn't worry too much about the crash screen being ugly. Making it easier to include the data it shows in a bug report is more important.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Component: ASM/C Changes some internals of the ASM/C libraries Status: Needs Review Someone should be looking at it Type: Maintenance Code style, infrastructure, updating dependencies

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants