Shorten crash debugger button code to first combo L+R+Z#2574
Open
djevangelia wants to merge 1 commit into
Open
Shorten crash debugger button code to first combo L+R+Z#2574djevangelia wants to merge 1 commit into
djevangelia wants to merge 1 commit into
Conversation
|
Honestly, it'd be best to remove the combination entirely and just bring it up right away. People never realize there is a debugger and don't include it in bug reports because they don't know about it. |
Collaborator
|
Agreed. A crash means something has already gone very wrong, so I wouldn't worry too much about the crash screen being ugly. Making it easier to include the data it shows in a bug report is more important. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This shortens the button sequence to show the crash debugger to the first combination only, L + R and Z.
My reasoning is that not every player wants to get a sudden big ugly scary crash screen if they crash, yet might need to easily open it for a bug report (I will admit I have never been able to successfully enter the full code), and anyone who needs instant screen for debugging purposes can nop the jumps to
Fault_WaitForButtonCombothemselves.The downside could be that sometimes some emulators don't seem to display the yellow crash bar (which could make instant screen better), but if the combo is easy and players know about it, I think they'll try it out on crashing anyways if interested in bug reporting.
Testing
Tested in Ares recent nightly build and Project64 3.0.1.
https://www.youtube.com/watch?v=GmMi43YtEiM
One way to test quickly is to change this code in hacks.asm:
Test usual crash: Change
sw v1,...tosb v1,...Test HungUp: Change everything to