Change conditions for extended minimaps + dynamic load#2579
Open
djevangelia wants to merge 3 commits into
Open
Change conditions for extended minimaps + dynamic load#2579djevangelia wants to merge 3 commits into
djevangelia wants to merge 3 commits into
Conversation
Collaborator
|
For future reference, you can make GitHub link an issue using |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change the conditions for extended minimaps to fit randomizer and make loading dynamic. Implements/"fixes" #2403.
Changes have been made in line with the suggestions in the issue and comment:
Changes have been made to the Lake Hylia water functions, but nothing regarding gameplay function. Rather just things like setting action function
DoNothingif Morpha not killed (instead of always setting and running the water level function) and not checking Morpha kill in the water level function (because it has already been checked by the gossip stone - and surely, it shouldn't be needed there either, becauseDoNothingwould be set if not killed?).Also, I added static asserts to the sizes of
z64_game_t,z64_link_tandz64_file_tbecause it's so easy to get lost when replacing unknown chars with the real members and getting very amusing bugs that are totally impossible to debug until you remember you tinkered with one such file.Disassembly
Map_InitData NTSC 1.0 matching disassembly here https://gist.github.com/djevangelia/cc1bfe60ad98f9d4c4c6fc6aa6793f39
Testing
Tested in Ares recent nightly build.
Looks like this: https://www.youtube.com/watch?v=GaAn8YkbORA
I removed the Morpha requirement here, but have tested with it both before and after killing.