Enable overriding rainbow tunics#2582
Merged
Merged
Conversation
fenhl
added
Type: Bug
fenhl
approved these changes
May 22, 2026
fenhl
added
Status: Waiting for Release
Collaborator
|
Thank you for the PR! We may have to make a hotfix release (see #dev-public-talk for discussion) so marking this as waiting for release and merging once that's resolved. |
Author
Good to know, thanks Fenhl! |
fenhl
removed
the
Status: Waiting for Release
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug where, if a seed is generated with rainbow tunics, then the tunic colors cannot be overridden. This happened because the rainbow tunic bits that are set by the person generating the seed could never be unset. Fix is simply to 0 out the rainbow tunic bits before applying the selected cosmetics.
Testing
Generated patch files before and after the change, and verified that post-change it's possible to override rainbow tunics.