Ladder cutscene fix without ra manipulation#2586
Merged
Merged
Conversation
fenhl
added
Type: Bug
Collaborator
|
@GSKirox will test on Dolphin. |
GSKirox
approved these changes
May 26, 2026
Collaborator
GSKirox
left a comment
GSKirox
left a comment
There was a problem hiding this comment.
Looks good to me, the only line i was scared of is the branch to load LinkAnimation, but this was cleared by both djevangelia and cadmic on discord.
Collaborator
|
Tested the fix on Dolphin and no issue. |
Collaborator
|
I'm not sure what this fail check is about though, complaining about a missing label in message.asm when this PR doesn't touch it at all? |
|
Same issue is on master, so unlikely to do with this PR |
Author
|
I didn't include the binary files because it thinks mine are outdated anyway. |
fenhl
removed
Status: Needs Review
TreZc0
pushed a commit
that referenced
this pull request
May 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For VC recompiler safety.
Disassembly
Player_Action_DismountLadderhereTesting
Tested in Ares recent nightly build and Project64 3.0.1.
Follow along the assembly: https://www.youtube.com/watch?v=Fz2gKoqViCg
Still can't get Dolphin to work so can't test that.