Language: Resource Warning and Fill Error resolve

[JackTriton]

When using Unittest.py, it'll raise ResourseWarning because of json.load(open(...))
I made sure that load and open are now separated

Also, there was an error with Fill.py and EntranceShuffle.py while Unittest
This was caused around entrance.sav so I inspect all of the files and found out that unrelated RNG causing this (around Language functions)
I changed the RNG distribution on World.py and Main.py and now it's fixed

[mracsys]

RNG should not need to be reset like this (and the attempt == 1 branch doesn't seem to do anything, should have been > 1 and no else branch).

If the settings object is not fully resolved or is tweaked by the language stuff after resolve_settings, there is a bigger fundamental problem that needs to be fixed.

[JackTriton]

Ok, should I avoid the changes I made with World.py as well?

[mracsys]

Yep.

[JackTriton]

Ok, I'll find a way to resolve the issue without changing these 2

[JackTriton]

@mracsys I think I found the reason: __version__ change
numeric_seed is calculated using settings_string + distribution + __version__ + seed
This change causing some kind of error so releasing version won't have the issue
What kind of fix should be suitable for this?

EDIT: The issue won't be raised if the version becomes 9.1.17 f.LUM

[flagrama]

If you are talking about the same random EntranceShuffle error that occasionally shows up in the Unit Tests that I think you are, it is usually fine and can be ignored if you can verify another seed does not cause the issue.

[JackTriton]

@flagrama Thanks
I think that's the case as well

[mracsys]

@mracsys I think I found the reason: __version__ change numeric_seed is calculated using settings_string + distribution + __version__ + seed This change causing some kind of error so releasing version won't have the issue What kind of fix should be suitable for this?

EDIT: The issue won't be raised if the version becomes 9.1.17 f.LUM

Should be good as-is for now like flag and others said. Eventually the test should be hardened as discussed on Discord, though that should be a separate PR IMO.