Redirect to the web UI on "GET /" request (#394)

Author: jgfoster

src/Devices/EthernetServer_TC.cpp

@@ -60,7 +60,10 @@ void EthernetServer_TC::echo() {
 
 // Handles an HTTP GET request
 void EthernetServer_TC::get() {
-  if (memcmp_P(buffer + 5, F("echo"), 4) == 0) {
+  if (memcmp_P(buffer + 4, F("/ "), 2) == 0) {
+    sendHomeRedirect();
+    state = FINISHED;
+  } else if (memcmp_P(buffer + 5, F("echo"), 4) == 0) {
     echo();
   } else if (memcmp_P(buffer + 5, F("api"), 3) == 0) {
     getApiHandler();
@@ -496,6 +499,16 @@ void EthernetServer_TC::sendDisplayRedirect() {
   client.write(buffer);
 }
 
+void EthernetServer_TC::sendHomeRedirect() {
+  const __FlashStringHelper *response_303 =
+      F("HTTP/1.1 303 See Other\r\n"
+        "Location: https://open-acidification.github.io/TankControllerManager/\r\n"
+        "Access-Control-Allow-Origin: *\r\n"
+        "\r\n");
+  strscpy_P(buffer, response_303, sizeof(buffer));
+  client.write(buffer);
+}
+
 void EthernetServer_TC::sendResponse(int code) {
   const __FlashStringHelper *response_400 =
       F("HTTP/1.1 400 Bad Request\r\n"

src/Devices/EthernetServer_TC.h

@@ -67,27 +67,28 @@ class EthernetServer_TC : public EthernetServer {
 
   // instance methods: constructor
   EthernetServer_TC(uint16_t port);
-  // instance methods: utility
-  void sendHeadersWithSize(uint32_t size);
-  void sendResponse(int);
-  void sendCurrentRedirect();
-  void sendDisplayRedirect();
-  int weekday(int year, int month, int day);
-  // instance methods: HTTP
-  void get();
-  void post();
-  void put();
-  void options();
-  void echo();
-  void getApiHandler();
+
+  // other instance methods
   void currentData();
   void display();
+  void echo();
+  bool fileContinue();
+  void fileSetup();
+  void get();
+  void getApiHandler();
+  bool isRequestForExistingFile();
   void keypress();
-  void rootdirSetup();
+  void options();
+  void post();
+  void put();
   void rootdir();
+  void rootdirSetup();
+  void sendCurrentRedirect();
+  void sendDisplayRedirect();
+  void sendHeadersWithSize(uint32_t size);
+  void sendHomeRedirect();
+  void sendResponse(int);
   void testReadSpeed();
   void testWriteSpeed();
-  bool isRequestForExistingFile();
-  void fileSetup();
-  bool fileContinue();
+  int weekday(int year, int month, int day);
 };

test/EthernetServerTest.cpp

@@ -565,4 +565,38 @@ unittest(PUT_Kp) {
   assertEqual(1000.125, singleton->getKp());
 }
 
+unittest(home) {
+  EthernetServer_TC* server = EthernetServer_TC::instance();
+  server->setHasClientCalling(true);
+  delay(1);
+  server->loop();
+  EthernetClient_CI client = server->getClient();
+  const char request[] =
+      "GET / HTTP/1.1\r\n"
+      "Host: localhost:80\r\n"
+      "Accept: text/plain;charset=UTF-8\r\n"
+      "Accept-Encoding: identity\r\n"
+      "Accept-Language: en-US\r\n"
+      "\r\n";
+  client.pushToReadBuffer(request);
+  server->loop();
+  deque<uint8_t>* pBuffer = client.writeBuffer();
+  assertEqual(129, pBuffer->size());
+  String response;
+  while (!pBuffer->empty()) {
+    response.concat(pBuffer->front());
+    pBuffer->pop_front();
+  }
+  const char expectedResponse[] =
+      "HTTP/1.1 303 See Other\r\n"
+      "Location: https://open-acidification.github.io/TankControllerManager/\r\n"
+      "Access-Control-Allow-Origin: *\r\n"
+      "\r\n";
+  assertEqual(expectedResponse, response);
+  server->loop();
+  assertEqual(NOT_CONNECTED, server->getState());
+  client.stop();
+  server->loop();
+}
+
 unittest_main()