Add more lint checks (#439)

* Update packages & fix lint issues.
* Update SDK version.
* Update flutter-version for flutterLint workflow.
* Apply more lint rules.

Author: jgfoster

.github/workflows/flutterLint.yaml

@@ -8,11 +8,12 @@ jobs:
       - uses: actions/checkout@v3
       - uses: subosito/flutter-action@v2
         with:
-          flutter-version: '3.7.6'
+          flutter-version: '3.13.5'
           channel: 'stable'
 
       - name: Install dependencies
         run: |
+          flutter --version
           cd extras/web_client
           flutter pub get
 

extras/log_file_server/analysis_options.yaml

@@ -15,9 +15,45 @@ include: package:lints/recommended.yaml
 
 # Uncomment the following section to specify additional rules.
 
-# linter:
-#   rules:
-#     - camel_case_types
+linter:
+  rules:
+    - always_put_control_body_on_new_line
+    - always_put_required_named_parameters_first
+    - always_use_package_imports
+    - avoid_bool_literals_in_conditional_expressions
+    - avoid_final_parameters
+    - avoid_void_async
+    - camel_case_types
+    - combinators_ordering
+    - conditional_uri_does_not_exist
+    - discarded_futures
+    - eol_at_end_of_file
+    - leading_newlines_in_multiline_strings
+    - literal_only_boolean_expressions
+    - matching_super_parameters
+    - no_adjacent_strings_in_list
+    - no_literal_bool_comparisons
+    - no_self_assignments
+    - no_wildcard_variable_uses
+    - parameter_assignments
+    - prefer_final_in_for_each
+    - prefer_final_locals
+    - prefer_single_quotes
+    - require_trailing_commas
+    - sort_constructors_first
+    - sort_pub_dependencies
+    - sort_unnamed_constructors_first
+    - throw_in_finally
+    - type_annotate_public_apis
+    - unawaited_futures
+    - unnecessary_await_in_return
+    - unnecessary_parenthesis
+    - unnecessary_raw_strings
+    - unnecessary_statements
+    - unreachable_from_main
+    - use_colored_box
+    - use_decorated_box
+    - use_enums
 
 # analyzer:
 #   exclude:

extras/log_file_server/bin/server.dart

@@ -15,34 +15,34 @@ final _router = Router()
   ..post('/logs/<path>', _post);
 
 Future<Response> _delete(Request req) async {
-  var file = File('$rootDir/deleteMe.log');
+  final file = File('$rootDir/deleteMe.log');
   if (file.existsSync()) {
     await file.delete();
   }
   return Response.ok(null);
 }
 
 Future<Response> _get(Request req, String path) async {
-  var file = File('$rootDir/$path');
+  final file = File('$rootDir/$path');
   if (!file.existsSync()) {
     return Response.notFound(null);
   }
-  var body = file.readAsStringSync();
+  final body = file.readAsStringSync();
   return Response.ok(body);
 }
 
 Future<Response> _head(Request req, String path) async {
-  var file = File('$rootDir/$path');
+  final file = File('$rootDir/$path');
   if (!file.existsSync()) {
     return Response.notFound(null);
   }
-  var length = file.lengthSync();
+  final length = file.lengthSync();
   return Response.ok(null, headers: {'content-length': '$length'});
 }
 
 Future<Response> _post(Request req, String path) async {
   // validate received data
-  var mimeType = req.mimeType;
+  final mimeType = req.mimeType;
   if (mimeType != 'text/plain') {
     return Response.badRequest(body: 'Content-Type must be text/plain!');
   }
@@ -51,12 +51,13 @@ Future<Response> _post(Request req, String path) async {
   }
 
   // get body
-  var length = req.contentLength;
-  var body = await req.readAsString();
+  final length = req.contentLength;
+  final body = await req.readAsString();
   if (length != body.length) {
     return Response.badRequest(
-        body: 'Content-Length of $length '
-            'did not match body.length of ${body.length}!');
+      body: 'Content-Length of $length '
+          'did not match body.length of ${body.length}!',
+    );
   }
 
   // // get remote address
@@ -65,7 +66,7 @@ Future<Response> _post(Request req, String path) async {
   // var remoteAddress = connectionInfo.remoteAddress.address;
   // print('remoteAddress = "$remoteAddress" (${remoteAddress.runtimeType})');
 
-  var file = File('$rootDir/$path');
+  final file = File('$rootDir/$path');
   file.createSync(exclusive: false);
   file.writeAsStringSync(
     body,
@@ -75,7 +76,7 @@ Future<Response> _post(Request req, String path) async {
 }
 
 void main(List<String> args) async {
-  Directory(rootDir).create(recursive: true);
+  await Directory(rootDir).create(recursive: true);
 
   // Use any available host or container IP (usually `0.0.0.0`).
   final ip = InternetAddress.anyIPv4;

extras/log_file_server/pubspec.lock

@@ -5,18 +5,18 @@ packages:
     dependency: transitive
     description:
       name: _fe_analyzer_shared
-      sha256: eb376e9acf6938204f90eb3b1f00b578640d3188b4c8a8ec054f9f479af8d051
+      sha256: "36a321c3d2cbe01cbcb3540a87b8843846e0206df3e691fa7b23e19e78de6d49"
       url: "https://pub.dev"
     source: hosted
-    version: "64.0.0"
+    version: "65.0.0"
   analyzer:
     dependency: transitive
     description:
       name: analyzer
-      sha256: "69f54f967773f6c26c7dcb13e93d7ccee8b17a641689da39e878d5cf13b06893"
+      sha256: dfe03b90ec022450e22513b5e5ca1f01c0c01de9c3fba2f7fd233cb57a6b9a07
       url: "https://pub.dev"
     source: hosted
-    version: "6.2.0"
+    version: "6.3.0"
   args:
     dependency: "direct main"
     description:
@@ -61,10 +61,10 @@ packages:
     dependency: transitive
     description:
       name: coverage
-      sha256: "2fb815080e44a09b85e0f2ca8a820b15053982b2e714b59267719e8a9ff17097"
+      sha256: "8acabb8306b57a409bf4c83522065672ee13179297a6bb0cb9ead73948df7c76"
       url: "https://pub.dev"
     source: hosted
-    version: "1.6.3"
+    version: "1.7.2"
   crypto:
     dependency: transitive
     description:
@@ -101,10 +101,10 @@ packages:
     dependency: "direct dev"
     description:
       name: http
-      sha256: "5895291c13fa8a3bd82e76d5627f69e0d85ca6a30dcac95c4ea19a5d555879c2"
+      sha256: "759d1a329847dd0f39226c688d3e06a6b8679668e350e2891a6474f8b4bb8525"
       url: "https://pub.dev"
     source: hosted
-    version: "0.13.6"
+    version: "1.1.0"
   http_methods:
     dependency: transitive
     description:
@@ -165,18 +165,18 @@ packages:
     dependency: transitive
     description:
       name: matcher
-      sha256: "1803e76e6653768d64ed8ff2e1e67bea3ad4b923eb5c56a295c3e634bad5960e"
+      sha256: d2323aa2060500f906aa31a895b4030b6da3ebdcc5619d14ce1aada65cd161cb
       url: "https://pub.dev"
     source: hosted
-    version: "0.12.16"
+    version: "0.12.16+1"
   meta:
     dependency: transitive
     description:
       name: meta
-      sha256: "3c74dbf8763d36539f114c799d8a2d87343b5067e9d796ca22b5eb8437090ee3"
+      sha256: d584fa6707a52763a52446f02cc621b077888fb63b93bbcb1143a7be5a0c0c04
       url: "https://pub.dev"
     source: hosted
-    version: "1.9.1"
+    version: "1.11.0"
   mime:
     dependency: transitive
     description:
@@ -205,10 +205,10 @@ packages:
     dependency: transitive
     description:
       name: path
-      sha256: "8829d8a55c13fc0e37127c29fedf290c102f4e40ae94ada574091fe0ff96c917"
+      sha256: "087ce49c3f0dc39180befefc60fdb4acd8f8620e5682fe2476afd0b3688bb4af"
       url: "https://pub.dev"
     source: hosted
-    version: "1.8.3"
+    version: "1.9.0"
   pool:
     dependency: transitive
     description:
@@ -325,26 +325,26 @@ packages:
     dependency: "direct dev"
     description:
       name: test
-      sha256: "9b0dd8e36af4a5b1569029949d50a52cb2a2a2fdaa20cebb96e6603b9ae241f9"
+      sha256: "3d028996109ad5c253674c7f347822fb994a087614d6f353e6039704b4661ff2"
       url: "https://pub.dev"
     source: hosted
-    version: "1.24.6"
+    version: "1.25.0"
   test_api:
     dependency: transitive
     description:
       name: test_api
-      sha256: "5c2f730018264d276c20e4f1503fd1308dfbbae39ec8ee63c5236311ac06954b"
+      sha256: "9955ae474176f7ac8ee4e989dadfb411a58c30415bcfb648fa04b2b8a03afa7f"
       url: "https://pub.dev"
     source: hosted
-    version: "0.6.1"
+    version: "0.7.0"
   test_core:
     dependency: transitive
     description:
       name: test_core
-      sha256: "4bef837e56375537055fdbbbf6dd458b1859881f4c7e6da936158f77d61ab265"
+      sha256: "2bc4b4ecddd75309300d8096f781c0e3280ca1ef85beda558d33fcbedc2eead4"
       url: "https://pub.dev"
     source: hosted
-    version: "0.5.6"
+    version: "0.6.0"
   typed_data:
     dependency: transitive
     description:
@@ -357,10 +357,10 @@ packages:
     dependency: transitive
     description:
       name: vm_service
-      sha256: "0fae432c85c4ea880b33b497d32824b97795b04cdaa74d270219572a1f50268d"
+      sha256: a2662fb1f114f4296cf3f5a50786a2d888268d7776cf681aa17d660ffa23b246
       url: "https://pub.dev"
     source: hosted
-    version: "11.9.0"
+    version: "14.0.0"
   watcher:
     dependency: transitive
     description:
@@ -369,22 +369,30 @@ packages:
       url: "https://pub.dev"
     source: hosted
     version: "1.1.0"
+  web:
+    dependency: transitive
+    description:
+      name: web
+      sha256: edc8a9573dd8c5a83a183dae1af2b6fd4131377404706ca4e5420474784906fa
+      url: "https://pub.dev"
+    source: hosted
+    version: "0.4.0"
   web_socket_channel:
     dependency: transitive
     description:
       name: web_socket_channel
-      sha256: d88238e5eac9a42bb43ca4e721edba3c08c6354d4a53063afaa568516217621b
+      sha256: "045ec2137c27bf1a32e6ffa0e734d532a6677bf9016a0d1a406c54e499ff945b"
       url: "https://pub.dev"
     source: hosted
-    version: "2.4.0"
+    version: "2.4.1"
   webkit_inspection_protocol:
     dependency: transitive
     description:
       name: webkit_inspection_protocol
-      sha256: "67d3a8b6c79e1987d19d848b0892e582dbb0c66c57cc1fef58a177dd2aa2823d"
+      sha256: "87d3f2333bb240704cd3f1c6b5b7acd8a10e7f0bc28c28dcf14e782014f4a572"
       url: "https://pub.dev"
     source: hosted
-    version: "1.2.0"
+    version: "1.2.1"
   yaml:
     dependency: transitive
     description:
@@ -394,4 +402,4 @@ packages:
     source: hosted
     version: "3.1.2"
 sdks:
-  dart: ">=3.0.6 <4.0.0"
+  dart: ">=3.2.0 <4.0.0"

extras/log_file_server/pubspec.yaml

@@ -4,14 +4,14 @@ version: 1.0.0
 # repository: https://github.com/my_org/my_repo
 
 environment:
-  sdk: ^3.0.6
+  sdk: '>=3.1.0 <4.0.0'
 
 dependencies:
   args: ^2.3.0
   shelf: ^1.4.0
   shelf_router: ^1.1.0
 
 dev_dependencies:
-  http: ^0.13.0
+  http: ^1.1.0
   lints: ^2.0.0
   test: ^1.21.0

extras/log_file_server/test/server_test.dart

@@ -1,41 +1,38 @@
-import 'dart:io';
-
 import 'package:http/http.dart';
 import 'package:test/test.dart';
 
 void main() {
   final port = '8080';
   final host = 'http://localhost:$port';
-  late Process p;
 
   // Start the server in a different shell before running tests
 
   test('HEAD for /logs/missing.log', () async {
-    var response = await head(Uri.parse('$host/logs/missing.log'));
+    final response = await head(Uri.parse('$host/logs/missing.log'));
     expect(response.statusCode, 404);
   });
 
   test('HEAD for /logs/empty.log', () async {
-    var response = await head(Uri.parse('$host/logs/empty.log'));
+    final response = await head(Uri.parse('$host/logs/empty.log'));
     expect(response.statusCode, 200);
     expect(response.headers['content-length'], '0');
   });
 
   test('HEAD for /logs/ten.log', () async {
-    var response = await head(Uri.parse('$host/logs/ten.log'));
+    final response = await head(Uri.parse('$host/logs/ten.log'));
     expect(response.statusCode, 200);
     expect(response.headers['content-length'], '10');
   });
 
   test('HEAD for /logs/../foo.log', () async {
-    var response = await head(Uri.parse('$host/logs/../foo.log'));
+    final response = await head(Uri.parse('$host/logs/../foo.log'));
     expect(response.statusCode, 404);
   });
 
   test('Write to /logs/deleteMe.log', () async {
-    var uri = Uri.parse('$host/logs/deleteMe.log');
-    var line1 = 'This is data for line 1\n';
-    var line2 = 'This is data for line 2\n';
+    final uri = Uri.parse('$host/logs/deleteMe.log');
+    final line1 = 'This is data for line 1\n';
+    final line2 = 'This is data for line 2\n';
 
     // delete the log file
     var response = await delete(uri);
@@ -56,13 +53,17 @@ void main() {
     // confirm the file's new size
     response = await head(uri);
     expect(response.statusCode, 200);
-    expect(response.headers['content-length'],
-        (line1.length + line2.length).toString());
+    expect(
+      response.headers['content-length'],
+      (line1.length + line2.length).toString(),
+    );
     // read the file and confirm the contents
     response = await get(uri);
     expect(response.statusCode, 200);
     expect(response.body, '$line1$line2');
-    expect(response.headers['content-length'],
-        (line1.length + line2.length).toString());
+    expect(
+      response.headers['content-length'],
+      (line1.length + line2.length).toString(),
+    );
   });
 }