Skip to content

List of children for trace: node#637

Merged
jreineckearm merged 5 commits into
Open-CMSIS-Pack:mainfrom
jreineckearm:trace-array
Jun 30, 2026
Merged

List of children for trace: node#637
jreineckearm merged 5 commits into
Open-CMSIS-Pack:mainfrom
jreineckearm:trace-array

Conversation

@jreineckearm

@jreineckearm jreineckearm commented Jun 30, 2026

Copy link
Copy Markdown
Collaborator

Fixes

Changes

  • Turn trace: children into a list.
  • Add transport mode specific child node types swo-uart and etb.
  • Update default name for trace output files (extended by optional trace config name that defaults to the transport mode like swo-uart or etb if not specified).
  • Added couple of missing links.

Note:

  • The child nodes with differing types do not match well what's currently available for user interface descriptions (debug adapter registry). If it helps, an alternative would be to have a single type for the list items where the transport mode is selectable as before the change and a name would be introduced. I don't think though it would massively solve the underlying problem of dynamically adjusting dialogs.

Checklist

  • 🤖 This change is covered by unit tests (if applicable).
  • 🤹 Manual testing has been performed (if necessary).
  • 🛡️ Security impacts have been considered (if relevant).
  • 📖 Documentation updates are complete (if required).
  • 🧠 Third-party dependencies and TPIP updated (if required).

Signed-off-by: Jens Reinecke <jens.reinecke@arm.com>
- Confusing duplication of `swo-uart`/`etb`
- Leftover use of trace mode in descriptions
- Bug in explanation

Signed-off-by: Jens Reinecke <jens.reinecke@arm.com>
Signed-off-by: Jens Reinecke <jens.reinecke@arm.com>

@RobertRostohar RobertRostohar left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Jens Reinecke <jens.reinecke@arm.com>
@jreineckearm jreineckearm marked this pull request as ready for review June 30, 2026 14:30
@jreineckearm jreineckearm merged commit a68b6d1 into Open-CMSIS-Pack:main Jun 30, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants