Skip to content

Commit 907ec3a

Browse files
bgn42brondani
authored andcommitted
Added missing check of return code
1 parent e7c9696 commit 907ec3a

1 file changed

Lines changed: 5 additions & 5 deletions

File tree

cmd/xml/pidx_test.go

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -58,15 +58,15 @@ func TestPdscTag(t *testing.T) {
5858

5959
t.Run("test IsDeprecated with empty string", func(t *testing.T) {
6060
pidx := xml.NewPidxXML("test.pidx", false)
61-
pidx.AddPdsc(xml.PdscTag{Vendor: "V", Name: "P", Version: "1.0.0"})
61+
assert.Nil(pidx.AddPdsc(xml.PdscTag{Vendor: "V", Name: "P", Version: "1.0.0"}))
6262
tags := pidx.FindPdscTags(xml.PdscTag{Vendor: "V", Name: "P", Version: "1.0.0"})
6363
assert.Equal(1, len(tags))
6464
assert.False(tags[0].IsDeprecated())
6565
})
6666

6767
t.Run("test IsDeprecated with past date", func(t *testing.T) {
6868
pidx := xml.NewPidxXML("test.pidx", false)
69-
pidx.AddPdsc(xml.PdscTag{Vendor: "V", Name: "P1", Version: "1.0.0", Deprecated: "2020-01-01"})
69+
assert.Nil(pidx.AddPdsc(xml.PdscTag{Vendor: "V", Name: "P1", Version: "1.0.0", Deprecated: "2020-01-01"}))
7070
tags := pidx.FindPdscTags(xml.PdscTag{Vendor: "V", Name: "P1", Version: "1.0.0"})
7171
assert.Equal(1, len(tags))
7272
assert.True(tags[0].IsDeprecated())
@@ -75,7 +75,7 @@ func TestPdscTag(t *testing.T) {
7575
t.Run("test IsDeprecated with today's date", func(t *testing.T) {
7676
today := time.Now().Format("2006-01-02")
7777
pidx := xml.NewPidxXML("test.pidx", false)
78-
pidx.AddPdsc(xml.PdscTag{Vendor: "V", Name: "P2", Version: "1.0.0", Deprecated: today})
78+
assert.Nil(pidx.AddPdsc(xml.PdscTag{Vendor: "V", Name: "P2", Version: "1.0.0", Deprecated: today}))
7979
tags := pidx.FindPdscTags(xml.PdscTag{Vendor: "V", Name: "P2", Version: "1.0.0"})
8080
assert.Equal(1, len(tags))
8181
assert.True(tags[0].IsDeprecated())
@@ -84,15 +84,15 @@ func TestPdscTag(t *testing.T) {
8484
t.Run("test IsDeprecated with future date", func(t *testing.T) {
8585
future := time.Now().AddDate(1, 0, 0).Format("2006-01-02")
8686
pidx := xml.NewPidxXML("test.pidx", false)
87-
pidx.AddPdsc(xml.PdscTag{Vendor: "V", Name: "P3", Version: "1.0.0", Deprecated: future})
87+
assert.Nil(pidx.AddPdsc(xml.PdscTag{Vendor: "V", Name: "P3", Version: "1.0.0", Deprecated: future}))
8888
tags := pidx.FindPdscTags(xml.PdscTag{Vendor: "V", Name: "P3", Version: "1.0.0"})
8989
assert.Equal(1, len(tags))
9090
assert.False(tags[0].IsDeprecated())
9191
})
9292

9393
t.Run("test IsDeprecated with invalid date", func(t *testing.T) {
9494
pidx := xml.NewPidxXML("test.pidx", false)
95-
pidx.AddPdsc(xml.PdscTag{Vendor: "V", Name: "P4", Version: "1.0.0", Deprecated: "not-a-date"})
95+
assert.Nil(pidx.AddPdsc(xml.PdscTag{Vendor: "V", Name: "P4", Version: "1.0.0", Deprecated: "not-a-date"}))
9696
tags := pidx.FindPdscTags(xml.PdscTag{Vendor: "V", Name: "P4", Version: "1.0.0"})
9797
assert.Equal(1, len(tags))
9898
assert.False(tags[0].IsDeprecated())

0 commit comments

Comments
 (0)