Issue #246, list --deprecated, implemented

DESIGN.md

@@ -203,7 +203,9 @@ The `configureInstaller` pre-run hook:
 | --- | --- |
 | `list` (default) | Lists all installed packs |
 | `list --cached` | Lists packs in `.Download/` |
-| `list --public` | Lists all packs from the public index |
+| `list --public` | Lists all non-deprecated packs from the public index |
+| `list --public --deprecated` | Lists all packs from the public index |
+| `list --deprecated` | Lists deprecated packs from the public index |
 | `list --updates` | Lists packs with newer versions available |
 | `list --filter` | Filters results (case-sensitive, accepts multiple expressions) |
 | `list-required` | Lists dependencies of installed packs |
@@ -239,11 +241,15 @@ type PacksInstallationType struct {
 - `UpdatePack()` — Updates one or all packs to latest versions
 - `InitializeCache()` — Builds `cache.pidx` from existing PDSC files in `.Web/`
 - `CheckConcurrency()` — Validates and adjusts the concurrent-downloads setting
-- `DownloadPDSCFiles()` — Downloads all PDSC files from the public index in parallel
+- `DownloadPDSCFiles()` — Downloads all PDSC files from the public
+  index in parallel, optionally skipping deprecated packs
 - `UpdateInstalledPDSCFiles()` — Refreshes already-cached PDSC files from the index
 - `UpdatePublicIndexIfOnline()` — Updates the public index only when connectivity is available
-- `UpdatePublicIndex()` — Downloads and updates the public index and PDSC files
-- `ListInstalledPacks()` — Lists packs with various filter modes
+- `UpdatePublicIndex()` — Downloads and updates the public index and
+  PDSC files, with option to skip deprecated PDSC files
+- `ListInstalledPacks()` — Lists packs with various filter modes;
+  supports `--deprecated` flag to show only deprecated packs
+  (hidden by default in `--public` listing)
 - `FindPackURL()` — Resolves a pack ID to a download URL from the index
 - `SetPackRoot()` — Initializes the `Installation` singleton and directory paths
 - `ReadIndexFiles()` — Loads `index.pidx`, `local_repository.pidx`, and `cache.pidx`
@@ -329,17 +335,19 @@ type PidxXML struct {
         Pdscs []PdscTag     // List of all pack references
     }
     // Internal lookup maps for O(1) access
-    pdscList     map[string][]int   // key → indices
-    pdscListName map[string][]int   // vendor.name → indices
+    pdscList       map[string][]PdscTag // key → PdscTags
+    pdscListName   map[string]string    // vendor.name → key
+    deprecatedDate time.Time            // today UTC, set once per Read()
 }
 
 type PdscTag struct {
-    URL         string   `xml:"url,attr"`
-    Vendor      string   `xml:"vendor,attr"`
-    Name        string   `xml:"name,attr"`
-    Version     string   `xml:"version,attr"`
-    Deprecated  string   `xml:"deprecated,attr,omitempty"`
-    Replacement string   `xml:"replacement,attr,omitempty"`
+    URL          string `xml:"url,attr"`
+    Vendor       string `xml:"vendor,attr"`
+    Name         string `xml:"name,attr"`
+    Version      string `xml:"version,attr"`
+    Deprecated   string `xml:"deprecated,attr,omitempty"`
+    Replacement  string `xml:"replacement,attr,omitempty"`
+    isDeprecated bool   // cached flag, computed on insert
 }
 ```
 
@@ -359,6 +367,11 @@ type PdscTag struct {
 - `YamlPackID()` — Returns `Vendor::Name@Version` format
 - `PackURL()` — Constructs the full `.pack` download URL (PdscTag method)
 - `PdscFileName()` — Returns the `.pdsc` filename (PdscTag method)
+- `IsDeprecated()` — Returns the cached deprecated flag.
+  Computed via `computeIsDeprecated()` when a PdscTag is
+  inserted (`Read`, `AddPdsc`, `AddReplacePdsc`).
+  Uses `PidxXML.deprecatedDate` (today UTC, set once per
+  `NewPidxXML`/`Read`) as reference (PdscTag method)
 
 ### 7.2 PDSC — Pack Description (`pdsc.go`)
 
@@ -666,7 +679,8 @@ All errors are predefined constants in `errors.go`, allowing consistent error ch
 Helper functions:
 
 - `Is()` — Wraps `errors.Is()` for convenience
-- `AlreadyLogged()` — Wraps errors to prevent the same message from being logged twice as the error travels up the call stack
+- `AlreadyLogged()` — Wraps errors to prevent the same message from
+  being logged twice as the error travels up the call stack
 
 ---
 
@@ -706,6 +720,7 @@ installer.UpdatePublicIndex()
   ├── Download new index.pidx from upstream URL
   ├── Compare old vs. new entries
   ├── Download updated/new PDSC files (concurrent, via semaphore)
+  │     └── Skip PDSC files where Deprecated date ≤ today
   ├── Update cache.pidx to reflect changes
   └── Remove deprecated entries
 ```

cmd/commands/init.go

@@ -14,6 +14,9 @@ var initCmdFlags struct {
 	// downloadPdscFiles forces all pdsc files from the public index to be downloaded
 	downloadPdscFiles bool
 
+	// Includes deprecated packs
+	includeDeprecated bool
+
 	// Reports encoded progress for files and download when used by other tools
 	encodedProgress bool
 
@@ -56,14 +59,15 @@ The index-url is mandatory. Ex "cpackget init --pack-root path/to/mypackroot htt
 			return err
 		}
 
-		err = installer.UpdatePublicIndex(indexPath, true, initCmdFlags.downloadPdscFiles, false, true, true, initCmdFlags.insecureSkipVerify, viper.GetInt("concurrent-downloads"), viper.GetInt("timeout"))
+		err = installer.UpdatePublicIndex(indexPath, true, initCmdFlags.downloadPdscFiles, false, !initCmdFlags.includeDeprecated, true, true, initCmdFlags.insecureSkipVerify, viper.GetInt("concurrent-downloads"), viper.GetInt("timeout"))
 		return err
 	},
 }
 
 func init() {
-	InitCmd.Flags().BoolVarP(&initCmdFlags.downloadPdscFiles, "all-pdsc-files", "a", false, "downloads all the latest .pdsc files from the public index")
-	InitCmd.Flags().BoolVarP(&initCmdFlags.encodedProgress, "encoded-progress", "E", false, "Reports encoded progress for files and download when used by other tools")
+	InitCmd.Flags().BoolVarP(&initCmdFlags.downloadPdscFiles, "all-pdsc-files", "a", false, "downloads all the latest .pdsc files from the public index, except deprecated ones")
+	InitCmd.Flags().BoolVarP(&initCmdFlags.includeDeprecated, "deprecated", "d", false, "includes deprecated .pdsc files when downloading")
+	InitCmd.Flags().BoolVarP(&initCmdFlags.encodedProgress, "encoded-progress", "E", false, "reports encoded progress for files and download when used by other tools")
 	InitCmd.Flags().BoolVar(&initCmdFlags.skipTouch, "skip-touch", false, "do not touch pack.idx")
 	InitCmd.Flags().BoolVar(&initCmdFlags.insecureSkipVerify, "insecure-skip-verify", false, "skip verification of server's TLS certificate when downloading packs over HTTPS")
 }

cmd/commands/list.go

@@ -19,18 +19,21 @@ var listCmdFlags struct {
 	// listCached tells whether listing all cached packs
 	listCached bool
 
+	// listDeprecated tells whether listing all deprecated packs
+	listDeprecated bool
+
 	// listFilter is a set of words by which to filter listed packs
 	listFilter string
 }
 
 var ListCmd = &cobra.Command{
-	Use:               "list [--cached|--public|--updates]",
+	Use:               "list [--cached|--public|--updates|--deprecated] [--filter <expression>]",
 	Short:             "List installed packs",
 	Long:              "List all installed packs and optionally cached packs or those for which updates are available",
 	Args:              cobra.MaximumNArgs(0),
 	PersistentPreRunE: configureInstaller,
 	RunE: func(cmd *cobra.Command, args []string) error {
-		return installer.ListInstalledPacks(listCmdFlags.listCached, listCmdFlags.listPublic, listCmdFlags.listUpdates, false, false, listCmdFlags.listFilter)
+		return installer.ListInstalledPacks(listCmdFlags.listCached, listCmdFlags.listPublic, listCmdFlags.listUpdates, listCmdFlags.listDeprecated, false, false, listCmdFlags.listFilter)
 	},
 }
 
@@ -41,14 +44,15 @@ var listRequiredCmd = &cobra.Command{
 	Args:              cobra.MaximumNArgs(0),
 	PersistentPreRunE: configureInstaller,
 	RunE: func(cmd *cobra.Command, args []string) error {
-		return installer.ListInstalledPacks(listCmdFlags.listCached, listCmdFlags.listPublic, listCmdFlags.listUpdates, true, false, listCmdFlags.listFilter)
+		return installer.ListInstalledPacks(listCmdFlags.listCached, listCmdFlags.listPublic, listCmdFlags.listUpdates, listCmdFlags.listDeprecated, true, false, listCmdFlags.listFilter)
 	},
 }
 
 func init() {
 	ListCmd.Flags().BoolVarP(&listCmdFlags.listCached, "cached", "c", false, "list only cached packs")
 	ListCmd.Flags().BoolVarP(&listCmdFlags.listPublic, "public", "p", false, "list packs in the public index")
 	ListCmd.Flags().BoolVarP(&listCmdFlags.listUpdates, "updates", "u", false, "list packs which have newer versions")
+	ListCmd.Flags().BoolVarP(&listCmdFlags.listDeprecated, "deprecated", "d", false, "list only deprecated packs")
 	ListCmd.Flags().StringVarP(&listCmdFlags.listFilter, "filter", "f", "", "filter results (case sensitive, accepts several expressions)")
 	ListCmd.AddCommand(listRequiredCmd)
 

cmd/commands/root.go

@@ -79,7 +79,7 @@ func configureInstaller(cmd *cobra.Command, args []string) error {
 			// Exclude index updating commands to not double update
 			if cmd.Name() != "init" && cmd.Name() != "index" && cmd.Name() != "update-index" && cmd.Name() != "list" {
 				installer.UnlockPackRoot()
-				err = installer.UpdatePublicIndex(installer.ActualPublicIndex, true, false, false, false, true, false, 0, 0)
+				err = installer.UpdatePublicIndex(installer.ActualPublicIndex, true, false, false, true, false, true, false, 0, 0)
 				if err != nil {
 					return err
 				}

cmd/commands/update_index.go

@@ -17,6 +17,9 @@ var updateIndexCmdFlags struct {
 	// downloadPdscFiles forces all pdsc files from the public index to be downloaded
 	downloadUpdatePdscFiles bool
 
+	// Includes deprecated packs
+	includeDeprecated bool
+
 	// Reports encoded progress for files and download when used by other tools
 	encodedProgress bool
 
@@ -47,7 +50,7 @@ var UpdateIndexCmd = &cobra.Command{
 			return err
 		}
 
-		err = installer.UpdatePublicIndex("", updateIndexCmdFlags.sparse, false, updateIndexCmdFlags.downloadUpdatePdscFiles, true, true, updateIndexCmdFlags.insecureSkipVerify, viper.GetInt("concurrent-downloads"), viper.GetInt("timeout"))
+		err = installer.UpdatePublicIndex("", updateIndexCmdFlags.sparse, false, updateIndexCmdFlags.downloadUpdatePdscFiles, !updateIndexCmdFlags.includeDeprecated, true, true, updateIndexCmdFlags.insecureSkipVerify, viper.GetInt("concurrent-downloads"), viper.GetInt("timeout"))
 		return err
 	},
 }
@@ -59,8 +62,9 @@ By default it will also check if all PDSC files under .Web/ need update as well.
 
 func init() {
 	UpdateIndexCmd.Flags().BoolVarP(&updateIndexCmdFlags.sparse, "sparse", "s", false, "avoid updating the pdsc files within .Web/ folder")
-	UpdateIndexCmd.Flags().BoolVarP(&updateIndexCmdFlags.downloadUpdatePdscFiles, "all-pdsc-files", "a", false, "updates/downloads all the latest .pdsc files from the public index")
-	UpdateIndexCmd.Flags().BoolVarP(&updateIndexCmdFlags.encodedProgress, "encoded-progress", "E", false, "Reports encoded progress for files and download when used by other tools")
+	UpdateIndexCmd.Flags().BoolVarP(&updateIndexCmdFlags.downloadUpdatePdscFiles, "all-pdsc-files", "a", false, "updates/downloads all the latest .pdsc files from the public index, except deprecated ones")
+	UpdateIndexCmd.Flags().BoolVarP(&updateIndexCmdFlags.includeDeprecated, "deprecated", "d", false, "includes deprecated .pdsc files when downloading")
+	UpdateIndexCmd.Flags().BoolVarP(&updateIndexCmdFlags.encodedProgress, "encoded-progress", "E", false, "reports encoded progress for files and download when used by other tools")
 	UpdateIndexCmd.Flags().BoolVar(&updateIndexCmdFlags.skipTouch, "skip-touch", false, "do not touch pack.idx")
 	UpdateIndexCmd.Flags().BoolVar(&updateIndexCmdFlags.insecureSkipVerify, "insecure-skip-verify", false, "skip verification of server's TLS certificate when downloading packs over HTTPS")
 }

cmd/installer/root.go

@@ -674,19 +674,34 @@ func CheckConcurrency(concurrency int) int {
 //
 // Parameters:
 // - skipInstalledPdscFiles: If true, skips downloading PDSC files that are already installed.
+// - skipDeprecatedPdscFiles: If true, skips downloading PDSC files that are marked as deprecated.
 // - insecureSkipVerify: If true, skips TLS certificate verification for HTTPS downloads.
 // - concurrency: The number of concurrent downloads to allow. If 0, downloads are sequential.
 // - timeout: The timeout for each download operation.
 //
 // Returns:
 // - An error if there is an issue reading the public index XML or acquiring the semaphore.
-func DownloadPDSCFiles(skipInstalledPdscFiles, insecureSkipVerify bool, concurrency int, timeout int) error {
+func DownloadPDSCFiles(skipInstalledPdscFiles, skipDeprecatedPdscFiles, insecureSkipVerify bool, concurrency int, timeout int) error {
 	log.Info("Downloading all PDSC files available on the public index")
 	// if err := Installation.PublicIndexXML.Read(); err != nil {
 	// 	return err
 	// }
 
-	pdscTags := Installation.PublicIndexXML.ListPdscTags()
+	allPdscTags := Installation.PublicIndexXML.ListPdscTags()
+
+	// Filter out deprecated tags upfront if requested, so the job count
+	// used for progress reporting matches the actual number of downloads.
+	var pdscTags []xml.PdscTag
+	if skipDeprecatedPdscFiles {
+		for _, t := range allPdscTags {
+			if !t.IsDeprecated() {
+				pdscTags = append(pdscTags, t)
+			}
+		}
+	} else {
+		pdscTags = allPdscTags
+	}
+
 	numPdsc := len(pdscTags)
 	if numPdsc == 0 {
 		log.Info("(no packs in public index)")
@@ -940,7 +955,7 @@ func UpdatePublicIndexIfOnline() error {
 			err = Installation.checkUpdateCfg(&updateConf, true)
 			if err != nil {
 				UnlockPackRoot()
-				err1 := UpdatePublicIndex(ActualPublicIndex, false, false, false, false, false, false, 0, 0)
+				err1 := UpdatePublicIndex(ActualPublicIndex, false, false, false, true, false, false, false, 0, 0)
 				if err1 != nil {
 					log.Warnf("Cannot update public index: %v", err1)
 					return nil
@@ -954,7 +969,7 @@ func UpdatePublicIndexIfOnline() error {
 	// if public index does not or not yet exist then download without check
 	if !utils.FileExists(Installation.PublicIndex) {
 		UnlockPackRoot()
-		err1 := UpdatePublicIndex(ActualPublicIndex, false, false, false, false, false, false, 0, 0)
+		err1 := UpdatePublicIndex(ActualPublicIndex, false, false, false, true, false, false, false, 0, 0)
 		if err1 != nil {
 			log.Warnf("Cannot update public index: %v", err1)
 			return nil
@@ -974,6 +989,7 @@ func UpdatePublicIndexIfOnline() error {
 //   - sparse: A boolean flag to indicate whether to perform a sparse update.
 //   - downloadPdsc: A boolean flag to indicate whether to download PDSC files.
 //   - downloadRemainingPdscFiles: A boolean flag to indicate whether to download all remaining PDSC files.
+//   - skipDeprecatedPdscFiles: If true, skips downloading deprecated PDSC files.
 //   - updatePrivatePdsc: If true, updates private PDSC files during the update process.
 //   - showInfo: If true, logs informational messages about the download.
 //   - insecureSkipVerify: A boolean flag to indicate whether to skip TLS certificate verification for HTTPS downloads.
@@ -982,7 +998,7 @@ func UpdatePublicIndexIfOnline() error {
 //
 // Returns:
 //   - error: An error if the update fails, otherwise nil.
-func UpdatePublicIndex(indexPath string, sparse, downloadPdsc, downloadRemainingPdscFiles, updatePrivatePdsc, showInfo, insecureSkipVerify bool, concurrency int, timeout int) error {
+func UpdatePublicIndex(indexPath string, sparse, downloadPdsc, downloadRemainingPdscFiles, skipDeprecatedPdscFiles, updatePrivatePdsc, showInfo, insecureSkipVerify bool, concurrency int, timeout int) error {
 	// For backwards compatibility, allow indexPath to be a file, but ideally it should be empty
 	if indexPath == "" {
 		indexPath = strings.TrimSuffix(Installation.PublicIndexXML.URL, "/") + "/" + PublicIndexName
@@ -1043,7 +1059,7 @@ func UpdatePublicIndex(indexPath string, sparse, downloadPdsc, downloadRemaining
 	utils.SetReadOnly(Installation.PublicIndex)
 
 	if downloadPdsc {
-		err = DownloadPDSCFiles(false, insecureSkipVerify, concurrency, timeout)
+		err = DownloadPDSCFiles(false, skipDeprecatedPdscFiles, insecureSkipVerify, concurrency, timeout)
 		if err != nil {
 			return err
 		}
@@ -1066,7 +1082,7 @@ func UpdatePublicIndex(indexPath string, sparse, downloadPdsc, downloadRemaining
 	Installation.PublicIndexXML.SetFileName(savedIndexPath)
 
 	if downloadRemainingPdscFiles {
-		err = DownloadPDSCFiles(true, insecureSkipVerify, concurrency, timeout)
+		err = DownloadPDSCFiles(true, skipDeprecatedPdscFiles, insecureSkipVerify, concurrency, timeout)
 		if err != nil {
 			return err
 		}
@@ -1190,20 +1206,22 @@ func findInstalledPacks(addLocalPacks, removeDuplicates bool) ([]installedPack,
 //   - listCached: If true, lists the cached packs.
 //   - listPublic: If true, lists the packs from the public index.
 //   - listUpdates: If true, lists the installed packs with available updates.
+//   - listDeprecated: If true, lists the deprecated packs.
 //   - listRequirements: If true, lists the installed packs with dependencies.
+//   - testing: If true, skips reading index files (used for testing).
 //   - listFilter: A string to filter the packs by.
 //
 // Returns:
 //   - error: An error if any occurs during the listing process.
-func ListInstalledPacks(listCached, listPublic, listUpdates, listRequirements, testing bool, listFilter string) error {
+func ListInstalledPacks(listCached, listPublic, listUpdates, listDeprecated, listRequirements, testing bool, listFilter string) error {
 	log.Debugf("Listing packs")
 
 	if !testing {
 		if err := ReadIndexFiles(); err != nil {
 			return err
 		}
 	}
-	if listPublic {
+	if listPublic || listDeprecated {
 		if listFilter != "" {
 			log.Infof("Listing packs from the public index, filtering by %q", listFilter)
 		} else {
@@ -1222,7 +1240,18 @@ func ListInstalledPacks(listCached, listPublic, listUpdates, listRequirements, t
 		})
 		// List all available packs from the index
 		for _, pdscTag := range pdscTags {
+			isDeprecated := pdscTag.IsDeprecated()
+			// Filter by deprecated status:
+			// only --deprecated: show only deprecated packs
+			// only --public: hide deprecated packs
+			if (!listPublic && listDeprecated && !isDeprecated) ||
+				(listPublic && !listDeprecated && isDeprecated) {
+				continue
+			}
 			logMessage := pdscTag.YamlPackID()
+			if isDeprecated {
+				logMessage += " (deprecated)"
+			}
 			packFilePath := filepath.Join(Installation.DownloadDir, pdscTag.Key()) + utils.PackExtension
 
 			if ok, _ := Installation.PackIsInstalled(&PackType{PdscTag: pdscTag}, false); ok {