Use image_files map instead of symbol_files to find executable for Load+Run on FVP

[VladimirUmek]

No description provided.

[VladimirUmek]

This causes that hex image is used instead of axf to load application to FVP model.

[jkrech]

What if no hex file is present? Is then axf used?

[JonatanAntoni]

image_files is the list of all files marked as image or image+symbol in .cbuild-run.yml (https://open-cmsis-pack.github.io/cmsis-toolbox/YML-Input-Format/#load)

I guess .axf files are just .elf files and default to image+symbol if not configured differently.

However, I have never tried to load .hex files into a model.

[VladimirUmek]

Ah, sorry for my too brief comment. @jreineckearm and @RobertRostohar were also looking at this and know the context. I expected to mark them to review this PR but I don't have permissions to select reviewers.

Anyway, Jonatan explained the end effect.

In practice, currently, if there is only axf selected, axf gets loaded, if there is only hex, hex gets loaded. If there are both, hex gets loaded.

[jreineckearm]

Correct, discussed this with @RobertRostohar yesterday and he demonstrated the effect by modifying the templates in an installation.
Problem was again AC6 build output specifics around load/execution regions which caused the model to zero-initialize a huge range of memory (beyond what's defined for the target). The model uses a similar approach as GDB for loading.

Selecting image_files for the Run task fixes that. A debugger would then load the symbol_files.
See https://github.com/Open-CMSIS-Pack/debug-adapter-registry/blob/main/templates/JLink.adapter.json and https://github.com/Open-CMSIS-Pack/debug-adapter-registry/blob/main/templates/CMSIS-DAP-pyOCD.adapter.json which follow the same approach.

One thought coming to mind only now: are we using any FVP plugins that require debug symbols to be loaded into the model?

[jkrech]

I am not aware of any FVP plug-in we are using beyond the ones included

• CDELoader
• GenericTrace
• ListTraceSources
• TarmacTrace

I think we are find for now.

[jreineckearm]

Thanks for the reply. Agreed. Especially since it then "simply" is a matter of marking the files as needed if deviating from the default.