Skip to content

Rpc development (#1200)#2098

Merged
edriouk merged 1 commit into
Open-CMSIS-Pack:mainfrom
ARM-software:outbound/rpc-development
Jun 3, 2025
Merged

Rpc development (#1200)#2098
edriouk merged 1 commit into
Open-CMSIS-Pack:mainfrom
ARM-software:outbound/rpc-development

Conversation

@grasci-arm

Copy link
Copy Markdown
Collaborator
  • [projmgr] Introduce JSON-RPC server mode

  • Add GetComponentsInfo request

  • Add GetPacksInfo and ValidateComponents requests

  • Add GetLogMessages requests

  • Add bundles to GetComponentsInfo request

  • GetComponentsTree request added

  • Make more RPC data optional

  • Taxonomy

  • Fix for cclass level
    Initial unit tests preparation

  • Only report aggregates belonging to the bundle

  • report selected components in the tree

  • Fix adding api and taxonomy to group

  • Select methods and use of individual contexts

  • Check if component exists for variant change

  • add flag to list components from all packs

  • Components from all/solution packs

  • Extend jrpc commands and structures.
    Always write active bundle

  • Correct GetUsedData

  • Add layer information
    consistent use of selectedCount

  • Add layer filed to CtAggregate
    Ensure value is set and propagated.
    Remove Component Instance from CtAggregate structure
    Add helper method in XmlItem class to assign an attribute from one object to another

  • [json-rpc] Add RpcInterface.h


Co-authored-by: Daniel Brondani daniel.brondani@arm.com

* [projmgr] Introduce JSON-RPC server mode
* Add `GetComponentsInfo` request
* Add `GetPacksInfo` and `ValidateComponents` requests
* Add `GetLogMessages` requests
* Add `bundles` to `GetComponentsInfo` request
* GetComponentsTree  request added
* Make more RPC data optional
* Taxonomy
* Fix for cclass level
  Initial unit tests preparation
* Only report aggregates belonging to the bundle
* report selected components in the tree
* Fix adding api and taxonomy to group
* Select methods and use of individual contexts
* Check if component exists for variant change
* add flag to list components from all packs
* Components from all/solution packs
* Extend jrpc commands and structures.
Always write active bundle
* Correct GetUsedData
* Add layer information
consistent use of selectedCount
* Add layer filed to CtAggregate
Ensure value is set and propagated.
Remove Component Instance from CtAggregate structure
Add helper method in XmlItem class to assign an attribute from one object to another

* [json-rpc] Add `RpcInterface.h`

---------

Co-authored-by: Daniel Brondani <daniel.brondani@arm.com>
@github-actions

github-actions Bot commented Jun 3, 2025

Copy link
Copy Markdown

Test Results

  7 files   53 suites   4m 47s ⏱️
185 tests 168 ✅ 17 💤 0 ❌
692 runs  624 ✅ 68 💤 0 ❌

Results for commit 29f55fd.

♻️ This comment has been updated with latest results.

Comment thread tools/projmgr/include/RpcInterface.h Dismissed
Comment thread tools/projmgr/include/RpcInterface.h Dismissed
Comment thread tools/projmgr/include/RpcInterface.h Dismissed
Comment thread tools/projmgr/include/RpcInterface.h Dismissed
Comment thread tools/projmgr/include/RpcInterface.h Dismissed
Comment thread tools/projmgr/src/ProjMgrRpcServer.cpp Dismissed
Comment thread tools/projmgr/src/ProjMgrRpcServer.cpp Dismissed
Comment thread tools/projmgr/src/ProjMgrRpcServer.cpp Dismissed
Comment thread tools/projmgr/src/ProjMgrRpcServer.cpp Dismissed
Comment thread tools/projmgr/src/ProjMgrRpcServerData.cpp Dismissed
@edriouk edriouk merged commit 8c37dec into Open-CMSIS-Pack:main Jun 3, 2025
116 of 118 checks passed
@edriouk edriouk deleted the outbound/rpc-development branch June 3, 2025 13:31
@codecov

codecov Bot commented Jun 3, 2025

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 12.65060% with 580 lines in your changes missing coverage. Please review.

Project coverage is 65.36%. Comparing base (b4ab6b8) to head (29f55fd).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
tools/projmgr/src/ProjMgrRpcServer.cpp 2.02% 242 Missing ⚠️
tools/projmgr/src/ProjMgrRpcServerData.cpp 0.00% 152 Missing ⚠️
tools/projmgr/include/RpcInterface.h 0.00% 123 Missing ⚠️
tools/projmgr/include/ProjMgrWorker.h 0.00% 22 Missing ⚠️
tools/projmgr/src/ProjMgr.cpp 55.10% 22 Missing ⚠️
tools/projmgr/include/ProjMgrParser.h 0.00% 8 Missing ⚠️
tools/projmgr/include/ProjMgrExtGenerator.h 0.00% 3 Missing ⚠️
tools/projmgr/include/ProjMgrRunDebug.h 0.00% 3 Missing ⚠️
tools/projmgr/include/ProjMgrRpcServer.h 50.00% 2 Missing ⚠️
tools/projmgr/include/ProjMgr.h 0.00% 1 Missing ⚠️
... and 2 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2098      +/-   ##
==========================================
- Coverage   66.37%   65.36%   -1.01%     
==========================================
  Files         173      182       +9     
  Lines       36465    37081     +616     
  Branches    21229    21554     +325     
==========================================
+ Hits        24203    24238      +35     
- Misses       7878     8459     +581     
  Partials     4384     4384              
Flag Coverage Δ
buildmgr-cov 73.95% <ø> (ø)
packchk-cov 70.68% <ø> (ø)
packgen-cov 77.87% <ø> (ø)
projmgr-cov 78.83% <12.65%> (-3.16%) ⬇️
svdconv-cov 40.75% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
tools/projmgr/src/ProjMgrYamlParser.cpp 83.10% <100.00%> (+0.01%) ⬆️
tools/projmgr/test/src/ProjMgrRpcTests.cpp 100.00% <100.00%> (ø)
tools/projmgr/test/src/ProjMgrUnitTests.cpp 80.36% <ø> (ø)
tools/projmgr/test/src/ProjMgrWorkerUnitTests.cpp 65.58% <100.00%> (+0.02%) ⬆️
tools/projmgr/include/ProjMgr.h 0.00% <0.00%> (ø)
tools/projmgr/include/ProjMgrRpcServerData.h 0.00% <0.00%> (ø)
tools/projmgr/src/ProjMgrWorker.cpp 88.07% <97.67%> (+<0.01%) ⬆️
tools/projmgr/include/ProjMgrRpcServer.h 50.00% <50.00%> (ø)
tools/projmgr/include/ProjMgrExtGenerator.h 0.00% <0.00%> (ø)
tools/projmgr/include/ProjMgrRunDebug.h 25.00% <0.00%> (-75.00%) ⬇️
... and 6 more
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants