Skip to content

LoadPacks without context (#1255)#2130

Merged
edriouk merged 1 commit into
Open-CMSIS-Pack:mainfrom
ARM-software:outbound/RpcLoadPacks
Jul 2, 2025
Merged

LoadPacks without context (#1255)#2130
edriouk merged 1 commit into
Open-CMSIS-Pack:mainfrom
ARM-software:outbound/RpcLoadPacks

Conversation

@grasci-arm

Copy link
Copy Markdown
Collaborator

Does not require global ContextItem
Clear() is added to ProjMgr

Does not require global ContextItem
Clear() is added to ProjMgr
@github-actions

github-actions Bot commented Jul 2, 2025

Copy link
Copy Markdown

Test Results

    3 files     21 suites   12m 5s ⏱️
  397 tests   397 ✅ 0 💤 0 ❌
1 191 runs  1 191 ✅ 0 💤 0 ❌

Results for commit 5e8b336.

Comment thread tools/projmgr/src/ProjMgrWorker.cpp Dismissed
@edriouk edriouk merged commit f0df79b into Open-CMSIS-Pack:main Jul 2, 2025
33 checks passed
@edriouk edriouk deleted the outbound/RpcLoadPacks branch July 2, 2025 09:11
@codecov

codecov Bot commented Jul 2, 2025

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 87.50000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 66.01%. Comparing base (57988df) to head (5e8b336).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
tools/projmgr/src/ProjMgrRpcServer.cpp 66.66% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2130      +/-   ##
==========================================
+ Coverage   65.90%   66.01%   +0.10%     
==========================================
  Files         181      181              
  Lines       37220    37224       +4     
  Branches    21658    21657       -1     
==========================================
+ Hits        24531    24572      +41     
+ Misses       8244     8207      -37     
  Partials     4445     4445              
Flag Coverage Δ
projmgr-cov 80.44% <87.50%> (+0.25%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
tools/projmgr/include/ProjMgr.h 100.00% <ø> (ø)
tools/projmgr/include/ProjMgrWorker.h 77.27% <100.00%> (+77.27%) ⬆️
tools/projmgr/src/ProjMgr.cpp 81.46% <100.00%> (+0.88%) ⬆️
tools/projmgr/src/ProjMgrWorker.cpp 88.13% <100.00%> (-0.01%) ⬇️
tools/projmgr/src/ProjMgrRpcServer.cpp 39.77% <66.66%> (+0.67%) ⬆️

... and 3 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants