Skip to content

Fix crash in LoadPacks RPC call #2484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
edriouk merged 2 commits into from
May 21, 2026
Merged

Fix crash in LoadPacks RPC call #2484

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
75d65fb
Fix crash in LoadPacks RPC call
edriouk May 20, 2026
40b336d
Potential fix for pull request finding
edriouk May 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions tools/projmgr/src/ProjMgrRpcServer.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -304,6 +304,7 @@ RpcArgs::SuccessResult RpcHandler::LoadPacks(void) {
RpcArgs::SuccessResult result = {false};
m_manager.Clear();
m_solutionLoaded = false;
ProjMgrKernel::Get()->GetGlobalModel()->Clear();
m_worker.InitializeModel();
m_worker.SetLoadPacksPolicy(LoadPacksPolicy::ALL);
result.success = m_worker.LoadAllRelevantPacks();
Expand Down
5 changes: 3 additions & 2 deletions tools/projmgr/src/ProjMgrWorker.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ bool ProjMgrWorker::PushImageOnlyTargetType(const string& targetType, const vect
}
}
CollectionUtils::PushBackUniquely(imageOnlyTargetTypes, targetType);
return true;
return true;
}

void ProjMgrWorker::AddImageOnlyContext() {
Expand Down Expand Up @@ -522,6 +522,7 @@ bool ProjMgrWorker::CollectAllRequiredPdscFiles() {
}

bool ProjMgrWorker::LoadAllRelevantPacks() {
m_loadedPacks.clear(); // the list will be updated, is should not contain dangling pointers
Comment thread
edriouk marked this conversation as resolved.
Outdated
// Get required pdsc files
std::list<std::string> pdscFiles;
for (const auto& context : m_selectedContexts) {
Expand Down Expand Up @@ -6064,7 +6065,7 @@ bool ProjMgrWorker::CheckPackVerAndCollectRelNotes(std::vector<std::string>& res

vector<string> checkPackResults;
for (const auto& [packId, packInfo] : usedPacks) {
const string& currentVersion = packInfo.first;
const string& currentVersion = packInfo.first;
auto latestPack = latestPacks.find(packId);
if (latestPack == latestPacks.end()) {
checkPackResults.push_back(packId + "@" + currentVersion + " (not found in CMSIS pack root or project-specified pack paths)");
Expand Down
Loading