fixed comments

Author: thorstendb-ARM

src/debug-session/gdbtarget-debug-session.ts

@@ -106,7 +106,7 @@ export class GDBTargetDebugSession {
         return this.session.configuration.request === 'launch' && this.capabilities?.supportsTerminateRequest === true;
     }
 
-    /** Function returns string only in case of failure */
+    // Function returns string only in case of failure
     public async evaluateGlobalExpression(expression: string, context = 'hover'): Promise<DebugProtocol.EvaluateResponse['body'] | string> {
         try {
             const frameId = (vscode.debug.activeStackItem as vscode.DebugStackFrame)?.frameId ?? 0;

src/views/component-viewer/component-viewer-target-access.ts

@@ -87,7 +87,6 @@ export class ComponentViewerTargetAccess {
         } catch (error: unknown) {
             const errorMessage = (error as Error)?.message;
             logger.debug(`Session '${this._activeSession?.session.name}': Failed to evaluate name '${address}' - '${errorMessage}'`);
-            //return errorMessage === 'custom request failed' ? 'No active session' : errorMessage;
             return undefined;
         }
     }

src/views/component-viewer/data-host/access-host.ts

@@ -17,7 +17,7 @@
 
 import type { EvalValue, RefContainer } from '../parser-evaluator/ref-container';
 
-/** Concrete data I/O (memory/register access). */
+// Concrete data I/O (memory/register access).
 export interface DataAccessHost {
     // Value access acts on container.{anchor,offsetBytes,widthBytes}
     readValue(container: RefContainer): Promise<EvalValue>;            // may return undefined -> error

src/views/component-viewer/data-host/memory-host.ts

@@ -118,7 +118,7 @@ type ElementMeta = {
   elementSize?: number;           // known uniform stride when consistent
 };
 
-/** The piece your host delegates to for readValue/writeValue. */
+// The piece your host delegates to for readValue/writeValue.
 export class MemoryHost {
     private cache = new ValidatingCache<MemoryContainer>();
     private endianness: Endianness;
@@ -152,7 +152,7 @@ export class MemoryHost {
         return this.cache.ensure(varName, () => new MemoryContainer(varName), false);
     }
 
-    /** Read a value, using byte-only offsets and widths. */
+    // Read a value, using byte-only offsets and widths.
     public async readValue(ref: RefContainer): Promise<EvalValue> {
         const variableName = ref.anchor?.name;
         const widthBytes = ref.widthBytes ?? 0;
@@ -200,7 +200,7 @@ export class MemoryHost {
         return raw.slice();
     }
 
-    /** Read raw bytes without interpretation. */
+    // Read raw bytes without interpretation.
     public async readRaw(ref: RefContainer, size: number): Promise<Uint8Array | undefined> {
         const variableName = ref.anchor?.name;
         if (!variableName || size <= 0) {
@@ -211,7 +211,7 @@ export class MemoryHost {
         return container.read(byteOff, size).slice();
     }
 
-    /** Write a value, using byte-only offsets and widths. */
+    // Write a value, using byte-only offsets and widths.
     public async writeValue(ref: RefContainer, value: EvalValue, virtualSize?: number): Promise<void> {
         const variableName = ref.anchor?.name;
         const widthBytes = ref.widthBytes ?? 0;
@@ -425,20 +425,20 @@ export class MemoryHost {
         this.cache.clear();
     }
 
-    /** Number of array elements recorded for `name`. Defaults to 1 when unknown. */
+    // Number of array elements recorded for `name`. Defaults to 1 when unknown.
     public getArrayElementCount(name: string): number {
         const m = this.elementMeta.get(name);
         const n = m?.offsets.length ?? 0;
         return n > 0 ? n : 1;
     }
 
-    /** All recorded target base addresses (per append) for `name`. */
+    // All recorded target base addresses (per append) for `name`.
     public getArrayTargetBases(name: string): (number | undefined)[] {
         const m = this.elementMeta.get(name);
         return m ? m.bases.slice() : [];
     }
 
-    /** Target base address for element `index` of `name` (number | undefined). */
+    // Target base address for element `index` of `name` (number | undefined).
     public getElementTargetBase(name: string, index: number): number | undefined {
         const m = this.elementMeta.get(name);
         if (!m) {
@@ -452,7 +452,7 @@ export class MemoryHost {
         return m.bases.at(index);
     }
 
-    /** Optional: repair or set an address later. */
+    // Optional: repair or set an address later.
     public setElementTargetBase(name: string, index: number, base: number): void {
         const m = this.elementMeta.get(name);
         if (!m) {

src/views/component-viewer/model/scvd-item.ts

@@ -179,14 +179,6 @@ export class ScvdItem extends ScvdNode {
         return await this.property.getGuiValue();
     }
 
-    // public getGuiChildren(): ScvdGuiInterface[] {
-    //     const guiItems = [this.item, this.listOut, this.print]
-    //         .flat()                                 // merge
-    //         .filter(x => x.getGuiConditionResult())    // filter
-    //         .sort(this.sortByLine);                 // sort in-place, returned
-    //     return guiItems && guiItems.length > 0 ? guiItems : undefined;
-    // }
-
     public hasGuiChildren(): boolean {
         return this.item.length > 0 || this.listOut.length > 0 || this.print.length > 0;
     }

src/views/component-viewer/model/scvd-list-out.ts

@@ -82,20 +82,7 @@ export class ScvdListOut extends ScvdList {
         return newItem;
     }
 
-    // public getGuiChildren(): ScvdNode[] | undefined {
-    //     const guiItems = [this.item, this.listOut]
-    //         .flat()                                 // merge
-    //         .filter(x => x.getGuiConditionResult())    // filter
-    //         .sort(this.sortByLine);                 // sort in-place, returned
-    //     return guiItems && guiItems.length > 0 ? guiItems : undefined;
-    // }
-
-    // public hasGuiChildren(): boolean {
-    //     return this.item.length > 0 || this.listOut.length > 0;
-    // }
-
     public override async getGuiName(): Promise<string | undefined> {
         return undefined;
     }
-
 }

src/views/component-viewer/model/scvd-out.ts

@@ -121,16 +121,4 @@ export class ScvdOut extends ScvdNode {
     public override getValueType(): string | undefined {
         return this.type?.getValueType();
     }
-
-    // public getGuiChildren(): ScvdGuiInterface[] | undefined {
-    //     const guiItems = this.item
-    //         .filter(x => x.getGuiConditionResult())    // filter
-    //         .sort(this.sortByLine);                 // sort in-place, returned
-    //     return guiItems && guiItems.length > 0 ? guiItems : undefined;
-    // }
-
-    // public hasGuiChildren(): boolean {
-    //     return this.item.length > 0 || this.list.length > 0;
-    // }
-
 }

src/views/component-viewer/parser-evaluator/evaluator.ts

@@ -70,13 +70,13 @@ type Host = ModelHost & DataAccessHost & IntrinsicProvider;
 
 export interface EvalContextInit {
     data: Host;
-    /** Starting container for symbol resolution (root model). */
+    // Starting container for symbol resolution (root model).
     container: ScvdNode;
 }
 
 export class EvalContext {
     readonly data: Host;
-    /** Composite container context (root + last member/index/current). */
+    // Composite container context (root + last member/index/current).
     container: RefContainer;
 
     constructor(init: EvalContextInit) {
@@ -453,7 +453,7 @@ type LValue = {
     type: ScalarType | undefined;
 };
 
-/** Accumulate a byte offset into the container (anchor-relative). */
+// Accumulate a byte offset into the container (anchor-relative).
 function addByteOffset(ctx: EvalContext, bytes: number) {
     const c = ctx.container;
     const add = (bytes | 0);

src/views/component-viewer/parser-evaluator/intrinsics.ts

@@ -19,28 +19,28 @@ import type { EvalValue, RefContainer } from './model-host';
 import type { ScvdNode } from '../model/scvd-node';
 
 export interface IntrinsicDefinition {
-    /** Arguments should be identifier names (not evaluated values). */
+    // Arguments should be identifier names (not evaluated values).
     expectsNameArg?: boolean;
-    /** Allow CallExpression(Identifier(...)) as a fallback to EvalPointCall. */
+    // Allow CallExpression(Identifier(...)) as a fallback to EvalPointCall.
     allowCallExpression?: boolean;
-    /** Minimum positional arguments expected. */
+    // Minimum positional arguments expected.
     minArgs?: number;
-    /** Maximum positional arguments expected. */
+    // Maximum positional arguments expected.
     maxArgs?: number;
 }
 
 // formatPrintf is a host hook, not an intrinsic. Exclude it from intrinsic names.
 export type IntrinsicName = Exclude<keyof IntrinsicProvider, 'formatPrintf'>;
 
-/** Intrinsic hooks exposed by the host (built-ins plus pseudo-members). */
+// Intrinsic hooks exposed by the host (built-ins plus pseudo-members).
 export interface IntrinsicProvider {
     // Named intrinsics
     // Note: __GetRegVal(reg) is special-cased (no container); others use the explicit hooks below
     __GetRegVal(reg: string): Promise<number | bigint | undefined>;
     __FindSymbol(symbol: string): Promise<number | undefined>;
     __CalcMemUsed(stackAddress: number, stackSize: number, fillPattern: number, magicValue: number): Promise<number | undefined>;
 
-    /** sizeof-like intrinsic – semantics are host-defined (usually bytes). */
+    // sizeof-like intrinsic – semantics are host-defined (usually bytes).
     __size_of(symbol: string): Promise<number | undefined>;
 
     __Symbol_exists(symbol: string): Promise<number | undefined>;
@@ -55,7 +55,7 @@ export interface IntrinsicProvider {
     _addr(container: RefContainer): Promise<number | undefined>;    // added as var because arrays can have different base addresses
 }
 
-/** Intrinsics that expect identifier *names* instead of evaluated values. */
+// Intrinsics that expect identifier *names* instead of evaluated values.
 /**
  * Metadata describing special intrinsic handling. Used both by evaluator logic
  * and as the single source of truth for intrinsic names in type definitions.

src/views/component-viewer/parser-evaluator/model-host.ts

@@ -21,7 +21,7 @@ import type { ScvdNode } from '../model/scvd-node';
 
 export type { EvalValue, ScalarKind, ScalarType, RefContainer, DataAccessHost };
 
-/** Symbol/model resolution and metadata helpers (no direct memory I/O). */
+// Symbol/model resolution and metadata helpers (no direct memory I/O).
 export interface ModelHost {
     // Resolution APIs — must set container.current to the resolved ref on success
     getSymbolRef(container: RefContainer, name: string, forWrite?: boolean): Promise<ScvdNode | undefined>;
@@ -30,16 +30,16 @@ export interface ModelHost {
     // Advanced lookups / intrinsics use the whole container context
     resolveColonPath(container: RefContainer, parts: string[]): Promise<EvalValue>; // undefined => not found
     // Metadata (lets evaluator accumulate offsets itself)
-    /** Bytes per element (including any padding/alignment inside the array layout). */
+    // Bytes per element (including any padding/alignment inside the array layout).
     getElementStride(ref: ScvdNode): Promise<number>;                       // bytes per element
 
-    /** Member offset in bytes from base. */
+    // Member offset in bytes from base.
     getMemberOffset(base: ScvdNode, member: ScvdNode): Promise<number | undefined>;     // bytes
 
-    /** Explicit byte width helper for a ref. */
+    // Explicit byte width helper for a ref.
     getByteWidth(ref: ScvdNode): Promise<number | undefined>;
 
-    /** Provide an element model (prototype/type) for array-ish refs. */
+    // Provide an element model (prototype/type) for array-ish refs.
     getElementRef(ref: ScvdNode): Promise<ScvdNode | undefined>;
 
     /**