review work

Author: thorstendb-ARM

src/views/component-viewer/model/scvd-format-specifier.ts

@@ -19,16 +19,6 @@ import { NumberType, NumFormat } from './number-type';
 // https://arm-software.github.io/CMSIS-View/main/elem_component_viewer.html
 
 
-/*  Note:
-    Question 1 (HEX display of float):
-    What should be the expected behavior for displaying float32 and float64 values in hexadecimal format? Should they be shown as truncated unsigned integers (UINT) or in their raw IEEE representation?
-    A: show as truncated integers
-
-    Question 2 (0x000... padding):
-    What should be the maximum padding size for HEX zeros (0x000...<num>): 32 or 64?
-    A: show the value without padding zeros, i.e. 0x3, 0x3bc4
-*/
-
 export type FormatKind = 'int' | 'uint' | 'float' | 'unknown';
 export interface FormatTypeInfo {
     kind: FormatKind;

src/views/component-viewer/model/scvd-item.ts

@@ -36,9 +36,9 @@ export class ScvdItem extends ScvdNode {
 
     constructor(
         parent: ScvdNode | undefined,
-        cond?: string, // = '1',
-        bold?: string, // = '0',
-        alert?: string, // = '0',
+        cond?: string,
+        bold?: string,
+        alert?: string,
     ) {
         super(parent);
         if (cond !== undefined) {

src/views/component-viewer/model/scvd-register-access.ts

@@ -75,15 +75,16 @@ export class ScvdTypedefs extends ScvdNode {
 }
 
 /*
-import:
+    Member-import (Attribute import="symbol-name" from SCVD xml):
     Name of a symbol in the user application which is loaded into the debugger.
-    The underlaying data type of this symbol is used to:
-
+    The underlaying data type of this symbol is used to
     recalculate the value of the attribute size of this typedef element.
-    for member elements with no explicit attribute offset, the offset value of
+    For member elements with no explicit attribute offset, the offset value of
     matching member is set. If the member is not part of the symbol in the user
     application the attribute offset value is set to -1.
     __Offset_of can be used to check this value.
+
+    Currently this is not supported due to MS-DAP restrictions.
 */
 
 export class ScvdTypedef extends ScvdNode {

src/views/component-viewer/model/scvd-typedef.ts

@@ -13,22 +13,8 @@
  * See the License for the specific language governing permissions and
  * limitations under the License.
  */
-// generated with AI
 
-/**
- * Fast, reusable, error-tolerant expression parser with:
- *  - Assignment '=' (right-associative) and C-style compound assignments: +=, -=, *=, /=, %=, <<=, >>=, &=, ^=, |=
- *  - ++ / -- (both prefix and postfix)
- *  - Printf-like formatting segments: `%x[ expr ]` (x = ANY single non-space char) and `%%` (escaped percent)
- *  - Intrinsic evaluation-point calls:
- *      __CalcMemUsed, __FindSymbol, __GetRegVal, __Offset_of, __size_of, __Symbol_exists, __Running
- *  - Constant folding (never folds assignments; side-effecting nodes are kept as AST)
- *  - External symbol collection
- *  - Colon selector operators `typedef_name:member` and `typedef_name:member:enum`
- *  - Ternary conditional `?:` (right-associative)
- *
- * Intended to be instantiated once and reused: `const parser = new Parser();`
- */
+// generated with AI
 
 import { addVals, andVals, divVals, maskToBits, modVals, mulVals, orVals, sarVals, shlVals, subVals, toNumeric, xorVals } from './math-ops';
 import { INTRINSIC_DEFINITIONS, isIntrinsicName } from './intrinsics';

src/views/component-viewer/parser-evaluator/parser.ts

@@ -35,7 +35,11 @@ export class StatementListOut extends StatementBase {
         }
 
         await this.onExecute(executionContext, guiTree);
-        /*for (const child of this.children) {  // executed in list
+        /* Example code for evaluating children.
+           Normally this happens here, but in this case it’s done in onExecute
+           to account for the loop and its variables.
+
+        for (const child of this.children) {  // executed in list
             await child.executeStatement(executionContext, guiTree);
         }*/
     }

src/views/component-viewer/statement-engine/statement-list-out.ts

@@ -35,7 +35,11 @@ export class StatementList extends StatementBase {
         }
 
         await this.onExecute(executionContext, guiTree);
-        /*for (const child of this.children) {  // executed in list
+        /* Example code for evaluating children.
+           Normally this happens here, but in this case it’s done in onExecute
+           to account for the loop and its variables.
+
+        for (const child of this.children) {  // executed in list
             await child.executeStatement(executionContext, guiTree);
         }*/
     }

src/views/component-viewer/statement-engine/statement-list.ts

@@ -14,6 +14,8 @@
  * limitations under the License.
  */
 
+// generated with AI
+
 import { ScvdNode } from '../model/scvd-node';
 import { ExecutionContext } from '../scvd-eval-context';
 import { ScvdGuiTree } from '../scvd-gui-tree';