Skip to content

Update README.md and pictures for webview and dynamic view settings#1019

Merged
jreineckearm merged 8 commits into
mainfrom
doc-webview-viewSettings
Jun 19, 2026
Merged

Update README.md and pictures for webview and dynamic view settings#1019
jreineckearm merged 8 commits into
mainfrom
doc-webview-viewSettings

Conversation

@jthuangarm

@jthuangarm jthuangarm commented Jun 10, 2026

Copy link
Copy Markdown
Collaborator

Fixes

Blocked until PR#926 is merged.

Doc updates for

Checklist

  • 🤖 This change is covered by unit tests (if applicable).
  • 🤹 Manual testing has been performed (if necessary).
  • 🛡️ Security impacts have been considered (if relevant).
  • 📖 Documentation updates are complete (if required).
  • 🧠 Third-party dependencies and TPIP updated (if required).

@qltysh

qltysh Bot commented Jun 10, 2026

Copy link
Copy Markdown

Qlty


Coverage Impact

This PR will not change total coverage.

🚦 See full report on Qlty Cloud »

🛟 Help
  • Diff Coverage: Coverage for added or modified lines of code (excludes deleted files). Learn more.

  • Total Coverage: Coverage for the whole repository, calculated as the sum of all File Coverage. Learn more.

  • File Coverage: Covered Lines divided by Covered Lines plus Missed Lines. (Excludes non-executable lines including blank lines and comments.)

    • Indirect Changes: Changes to File Coverage for files that were not modified in this PR. Learn more.

@jreineckearm

Copy link
Copy Markdown
Collaborator

Still need to test the view state settings before reviewing the docs here.
Component Viewer and Core Peripherals screenshots may need another refresh depending on the outcome of feedback on #1018

@jreineckearm

Copy link
Copy Markdown
Collaborator

Design should be stable since last updates to #1018 . Please create new screenshots with the swapped expand/collapse buttons.

@jreineckearm jreineckearm left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, please review the two suggestions before we merge.

Comment thread README.md Outdated
Comment thread README.md Outdated

@jreineckearm jreineckearm left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM, not waiting for CI before merge in case it runs the full cycle. Only docs updates.

@jreineckearm jreineckearm marked this pull request as ready for review June 19, 2026 12:03
@jreineckearm jreineckearm merged commit c8450f0 into main Jun 19, 2026
9 checks passed
@jreineckearm jreineckearm deleted the doc-webview-viewSettings branch June 19, 2026 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants