Skip to content

Fix: Extract gdb packages in tar.xz format#699

Merged
jreineckearm merged 2 commits into
mainfrom
fix-download-gdb
Dec 17, 2025
Merged

Fix: Extract gdb packages in tar.xz format#699
jreineckearm merged 2 commits into
mainfrom
fix-download-gdb

Conversation

@JonatanAntoni
Copy link
Copy Markdown
Member

Fixes

Changes

Screenshots

Checklist

  • 🤖 This change is covered by unit tests (if applicable).
  • 🤹 Manual testing has been performed (if necessary).
  • 🛡️ Security impacts have been considered (if relevant).
  • 📖 Documentation updates are complete (if required).
  • 🧠 Third-party dependencies and TPIP updated (if required).

Comment thread yarn.lock Outdated
@qltysh
Copy link
Copy Markdown

qltysh Bot commented Dec 16, 2025

Qlty

Coverage Impact

This PR will not change total coverage.

🚦 See full report on Qlty Cloud »

🛟 Help
  • Diff Coverage: Coverage for added or modified lines of code (excludes deleted files). Learn more.

  • Total Coverage: Coverage for the whole repository, calculated as the sum of all File Coverage. Learn more.

  • File Coverage: Covered Lines divided by Covered Lines plus Missed Lines. (Excludes non-executable lines including blank lines and comments.)

    • Indirect Changes: Changes to File Coverage for files that were not modified in this PR. Learn more.

@jreineckearm
Copy link
Copy Markdown
Collaborator

Was bit worried about the dependency check seeing old versions coming in 😞
https://github.com/Open-CMSIS-Pack/vscode-cmsis-debugger/actions/runs/20276323958/job/58225989914?pr=699

@jreineckearm
Copy link
Copy Markdown
Collaborator

@JonatanAntoni , we should consider moving back to fast-extract in vsce-helper and try to address the flaky behavior you mentioned, differently. In contrast to decompress, fast-extract still seems to be actively maintained.

@jreineckearm
Copy link
Copy Markdown
Collaborator

Reviewed content of VSIX files in https://github.com/Open-CMSIS-Pack/vscode-cmsis-debugger/actions/runs/20302898382
All contain again GDB and pyOCD.
Tested Windows x64 version: launches as expected.
Currently running nightly build workflow on this branch to verify its content, too.

Copy link
Copy Markdown
Collaborator

@jreineckearm jreineckearm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works again, thanks for your help with this!

@jreineckearm jreineckearm merged commit 0caa1c4 into main Dec 17, 2025
23 checks passed
@jreineckearm jreineckearm deleted the fix-download-gdb branch December 17, 2025 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants